Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(vitest): enable github-actions-reporter #2683

Merged
merged 6 commits into from
Feb 25, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 24, 2024

Fixes #2673

The default reporter set would contain the github-actions-reporter, but we explicitly use the basic reporter.

We use the basic reporter instead of the default, because of the better log output.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Feb 24, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Feb 24, 2024
@ST-DDT ST-DDT self-assigned this Feb 24, 2024
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (c45537f) to head (7dd4371).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2683      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2815     2815              
  Lines      250304   250304              
  Branches     1084     1082       -2     
==========================================
- Hits       249245   249232      -13     
- Misses       1030     1043      +13     
  Partials       29       29              

see 1 file with indirect coverage changes

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 24, 2024

This works as expected, but maybe a bit too good:

grafik

It reports it for every CI run.
Should we limit that to a specific pipeline? Is that even possible?

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 24, 2024

If we use a customly assigned env variable for the preflight run, then we only get it once:

https://github.com/faker-js/faker/actions/runs/8030969890

grafik

@ST-DDT ST-DDT marked this pull request as ready for review February 24, 2024 14:02
@ST-DDT ST-DDT requested a review from a team as a code owner February 24, 2024 14:02
@ST-DDT ST-DDT requested a review from a team February 24, 2024 14:02
@ST-DDT ST-DDT enabled auto-merge (squash) February 25, 2024 21:06
@ST-DDT ST-DDT merged commit a6eda6f into next Feb 25, 2024
14 checks passed
@ST-DDT ST-DDT deleted the infra/vitest/github-reporter branch February 25, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vitest github actions reporter
3 participants