Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the duration of no tags available message #747

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

oscarli9
Copy link

@oscarli9 oscarli9 commented Mar 1, 2020

Added two other configurations for styles based on Crouton text duration, changed the duration of no tags available message from DURATION_SHORT(950ms) to DURATION_MEDIUM(1650ms) to fix issue #663

Added two other configurations for styles based on Crouton text duration, changed the duration of no tags available message from DURATION_SHORT(950ms) to DURATION_MEDIUM(1650ms) to fix issue federicoiosue#663
@federicoiosue
Copy link
Owner

Hi Oscar, in which way this would fix the issue? Isn't that a matter of ratio of text and delimited space sizes?

@oscarli9
Copy link
Author

Hi Federico. In the additional context of Issue #663, Adeel mentioned that "it's difficult to read all of the text in the message within the duration as it is very less" so I added more configurational options for message text duration and changed the original duration. For the issue mentioned in the title - text cut, I tried to reproduce the issue across many types of emulators. I found text cut would not happen on most of them but only on Galaxy Nexus as Adeel said, so I didn't really change the original text size/space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants