-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dolfinx 0.8 #764
Update dolfinx 0.8 #764
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #764 +/- ##
========================================
Coverage 98.92% 98.92%
========================================
Files 36 36
Lines 1580 1580
========================================
Hits 1563 1563
Misses 17 17 ☔ View full report in Codecov by Sentry. |
There is a random error ocuring on both conda and docker when running test_xdmf.py. Although it seems that all the tests pass in this file so I don't really know what is going on here.
|
The error that we are seeing here might be related to FEniCS/dolfinx#3162 We'll wait for a fix before merging this |
There is now 0.8.1 released, not sure if that helps with this bug? |
I've narrowed down the error to using
Running just test_multispecies_problem gives:
|
MWE to reproduce the random segmentation fault import numpy as np
import festim as F
from petsc4py import PETSc
for i in range(2):
my_model = F.HydrogenTransportProblem()
my_model.mesh = F.Mesh1D(np.linspace(0, 1, num=1000))
my_mat = F.Material(D_0=1.9e-7, E_D=0.2, name="my_mat")
my_subdomain = F.VolumeSubdomain1D(id=1, borders=[0, 1], material=my_mat)
my_model.subdomains = [my_subdomain]
my_model.species = [F.Species("H")]
my_model.temperature = 500
my_model.settings = F.Settings(atol=1e10, rtol=1e-10, transient=False)
my_model.initialise()
my_model.solver.convergence_criterion = "incremental"
ksp = my_model.solver.krylov_solver
opts = PETSc.Options()
option_prefix = ksp.getOptionsPrefix()
opts[f"{option_prefix}ksp_type"] = "cg"
opts[f"{option_prefix}pc_type"] = "gamg"
opts[f"{option_prefix}pc_factor_mat_solver_type"] = "mumps"
ksp.setFromOptions()
my_model.run() Randomly produces
|
I noticed that removing the lines
removes the random segfault |
02a374f
into
festim-dev:fenicsx
This PR just updates the version of dolfinx to 0.8.0