-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface concentration discontinuities (fenicsx) #878
Draft
RemDelaporteMathurin
wants to merge
69
commits into
festim-dev:fenicsx
Choose a base branch
from
RemDelaporteMathurin:discontinuity-generic
base: fenicsx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Interface concentration discontinuities (fenicsx) #878
RemDelaporteMathurin
wants to merge
69
commits into
festim-dev:fenicsx
from
RemDelaporteMathurin:discontinuity-generic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mDiscontinuous from the correct module
We have noticed crashed in 1D simulations with coarse meshes. This is a fix for it (needs testing and review) and the working example is here (works with this PR). |
Co-authored-by: jorgensd <dokken@simula.no>
We had a discussion with @jorgensd @jhdark and @JonathanGSDUFOUR and noticed weird things happening with the performance so we need to investigate. Otherwise I'll carry on writing tests for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A massive thank you to @jorgensd who was instrumental in getting this functionality in FESTIM 🥇
This PR is a first (big) step towards interface discontinuities in the
fenicsx
branch (#719).(requires #764)
This new approach to conservation of chemical potential relies on the mixed domain approach implemented in dolfinx 0.8.0 and based off a demo available here
I created a new problem class
HTransportProblemDiscontinuous
- which is not yet complete - to avoid breaking existing functionality. We will complete this class by integrating transient, post-processing, ICs, etc. Eventually this whole class will be merged withHydrogenTransportProblem
.In the current interface, users need to provide correspondence between surfaces and volumes as well as listing interfaces and which volumes they are connected to:
I believe this can be streamlined by FESTIM under the hood but I'll keep that for a future PR.
Proposed user interface:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist