Revamp notifications stylesheet #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more accurate for the usage, and will prevent issues in the future with upgrades to TypeScript.
davwheat
added
type/bug
type/cleanup
type/accessibility
askvortsov1
approved these changes
May 2, 2021
tankerkiller125
approved these changes
May 2, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2813. Progresses flarum/issue-archive#355.
Changes proposed in this pull request:
classListutil (clsx) instead of string interpolationThis should really have been multiple PRs... I got a little carried away.
Reviewers should focus on:
Anything I've missed or should be changed? It's a pretty big rewrite so I wouldn't be surprised! I tried to add some comments to the styles too to help the review process (and me if I ever wonder what on earth I was doing).
Screenshot
Confirmed