Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp notifications stylesheet #2822

Merged
merged 11 commits into from
May 2, 2021
Merged

Revamp notifications stylesheet #2822

merged 11 commits into from
May 2, 2021

Commits on Apr 29, 2021

  1. Use classList instead of string interpolation; reorder elements to ma… 

    …tch layout
    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    3bd1f12 View commit details
    Browse the repository at this point in the history

  2. Use classList instead of string interpolation; simplify conditional r… 

    …endering
    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    f9c4878 View commit details
    Browse the repository at this point in the history

  3. Use null instead of false as a default 

    This is more accurate for the usage, and will prevent issues in the future with upgrades to TypeScript.
    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6ddd126 View commit details
    Browse the repository at this point in the history

  4. Wrap notification content and time in one "title" element

    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    69602a7 View commit details
    Browse the repository at this point in the history

  5. Reorder 'mark read' button and title; switch to JSX

    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    b4d48c8 View commit details
    Browse the repository at this point in the history

  6. Rewrite of Notifications Less to use grid and flexbox 

    Woop woop! 🎉
    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    f1378a5 View commit details
    Browse the repository at this point in the history

  7. Fix hover/focus styles not working in dropdown

    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    ec84261 View commit details
    Browse the repository at this point in the history

  8. Prevent '0' unread showing

    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    0c5ec9d View commit details
    Browse the repository at this point in the history

  9. Use flexbox for notification group header

    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    c874b4c View commit details
    Browse the repository at this point in the history

  10. Set focus ring offset of -1px to prevent it overflowing dropdown/view… 

    …port
    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    7be4f5d View commit details
    Browse the repository at this point in the history

  11. Wrap group title in <span> to fix flexbox vertical align

    @davwheat
    davwheat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    565e27f View commit details
    Browse the repository at this point in the history