Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite AdminPage.js into Typescript #2996

Merged
merged 21 commits into from
Aug 23, 2021
Merged

Rewrite AdminPage.js into Typescript #2996

merged 21 commits into from
Aug 23, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jul 31, 2021 •
edited
Loading

Progresses #3533

Changes proposed in this pull request:

  • Rewrites the AdminPage component into Typescript
  • Add missing a11y attributes using random IDs
  • Add Page component attrs interface to be used in AdminPage

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@davwheat davwheat added this to the 1.1 milestone Jul 31, 2021
@davwheat davwheat self-assigned this Jul 31, 2021
@davwheat davwheat mentioned this pull request Aug 1, 2021
Closed
9 tasks
SychO9
SychO9 requested changes Aug 5, 2021
View reviewed changes
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
@davwheat davwheat requested a review from SychO9 August 9, 2021 16:04
SychO9
SychO9 requested changes Aug 10, 2021
View reviewed changes
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
@davwheat
Copy link
Member Author

Oops... Missed that one 🙈. Thanks! :)

SychO9
SychO9 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

askvortsov1
askvortsov1 requested changes Aug 19, 2021
View reviewed changes
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
js/src/admin/components/AdminPage.tsx Show resolved Hide resolved
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
js/src/admin/components/AdminPage.tsx Outdated Show resolved Hide resolved
@davwheat
Copy link
Member Author

Made a few changes. Will merge soon™️ if noone objects.

@davwheat davwheat merged commit 0a2b28e into master Aug 23, 2021
@davwheat davwheat deleted the dw/adminpage-ts-rewrite branch August 23, 2021 00:59
@askvortsov1 askvortsov1 mentioned this pull request Mar 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsevillamartin dsevillamartin dsevillamartin left review comments

@SychO9 SychO9 SychO9 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees

@davwheat davwheat

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@davwheat @dsevillamartin @SychO9 @askvortsov1