New features for admin users list #2998
Conversation
davwheat
force-pushed
the
dw/2988-user-list-upgrades
branch
from
536a41f
to
477b8e1
Compare
|
LOVE IT ♥ for the table column names, could we have it so that the first letter of each word is capitalized? (e.g. Display Name, Email Confirmed, etc). Edit: I would also suggest doing the same for the rest of the text on that page including the modal title to keep with the same consistency as the rest of the forum. Examples: |
|
This PR is getting a bit large. Maybe let's do searching and sorting in follow-ups? |
|
Good idea. I don't think I'll have time to do them soon anyway with the accessibility issues. Some of the changes (itemlists) make it easier than ever for an extension to modify the userlist to add search and sort, too :P |
|
I have not followed the progress here but if I may make a suggestion, could we make the display name column into the link to the user profile? I'm creating an extension that hides the username from everywhere, so in my extension I added a display name column that becomes the link. I see this PR will add the same column, but it wouldn't be a link. Or the profile link could be an action of its own instead of being one of the data columns. |
Btw, there's an issue in core for |
|
Will review once rebased. |
davwheat
force-pushed
the
dw/2988-user-list-upgrades
branch
from
8501868
to
d43b72f
Compare
|
Rebased! |
|
Ugh VS Code formatted the locale yml... On it |
| content() { | ||
| const fields = this.fields().toArray(); | ||
|
|
||
| console.log(this.state); |
| /** | ||
| * A Modal that allows admins to create a new user. | ||
| */ | ||
| export default class CreateUserModal extends Modal { |
There was a problem hiding this comment.
Is there any way we could use the same component for the Create and Edit modals?
| return items; | ||
| } | ||
|
|
||
| private twoWayLinkAttrs(key: keyof typeof this.state, valueName: string = 'value', eventName: string = 'oninput') { |
There was a problem hiding this comment.
This seems overly complex
| const indexOfSearch = location.hash.indexOf('?') + 1; | ||
| const search = indexOfSearch >= 0 ? location.hash.substr(indexOfSearch) : ''; | ||
|
|
||
| const params = new URLSearchParams(search); |
There was a problem hiding this comment.
I wonder if it might make sense to store this info in params namespaced by a table ID. That way, we could support having multiple tables on the same page, and also keep this logic in the table component.
Alternatively, we could support both modes, but error if more than one table / paginated list tries to use non-namespaced-mode?
davwheat
force-pushed
the
dw/2988-user-list-upgrades
branch
from
0fd5350
to
495e9a5
Compare
|
Hello, thank you for your pull request! In order to speed up future development, keep all work in one place, and take advantage of CI tools that can help us avoid breaking changes, we have moved all Flarum code to a single monorepo at flarum/framework. You can read more about this process in our dev diary. Unfortunately, pull requests can't be carried over to the monorepo, so we have to close all open pull requests. If this pull request is still relevant, please feel free to reopen it over on the monorepo. We apologize for the inconvenience, and hope you will consider contributing to Flarum again in the future. |
|
Please rebase it :) |
|
Have these improvements been abandoned or is it possible to continue the progress of them? I think it would be great to implement them in future versions of the core. I'm not sure if this is the proper place or the official forum to ask it. |
|
This is planned to be picked up again, can't say when that could be. |
|
Thanks for the quick response, I'm glad to know that this has not been forgotten. :) |
|
Sorry to revive the thread, it's been quite a while since September. Will there be any progress? |
Fixes #3742
Changes proposed in this pull request:
Add new features to the ACP users list:
?page=xxx, and button to copy a permalink to the current pageReviewers should focus on:
Screenshot
4uCxmzgf.mp4
Confirmed