Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved page navigation for users list #3741

Merged
merged 3 commits into from
Feb 21, 2023
Merged

feat: improved page navigation for users list #3741

merged 3 commits into from
Feb 21, 2023

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Feb 21, 2023 •
edited
Loading

Supersedes #2998

Progresses #3742

Changes proposed in this pull request:

  • add first/last page buttons
  • add page navigation by query parameter (actually part of the hash due to how the admin navigation system works)
  • add text box to navigate directly to a page number

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.7 milestone Feb 21, 2023
@davwheat davwheat self-assigned this Feb 21, 2023
@davwheat davwheat marked this pull request as ready for review February 21, 2023 11:19
@davwheat davwheat requested a review from a team as a code owner February 21, 2023 11:19
@davwheat davwheat merged commit 408a92b into main Feb 21, 2023
@davwheat davwheat deleted the dw/users-list/pagination-upgrades branch February 21, 2023 13:04
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

@SychO9 SychO9 SychO9 approved these changes

Assignees

@davwheat davwheat

Labels
prio/low type/feature
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@davwheat @imorland @SychO9