Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add display name column to admin users list #3740

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Feb 21, 2023

Supersedes #2998

Progresses #3742

Changes proposed in this pull request:

  • Adds a new display name column to the admin users list

Not all users have the same username and display name, so we should show both in the list of users.

Screenshot

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Feb 21, 2023
@davwheat davwheat requested a review from a team as a code owner February 21, 2023 10:05
@davwheat davwheat added this to the 1.7 milestone Feb 21, 2023
@jslirola
Copy link

I was going to send my comment when I saw that you have edited the description and you have clarified my question in a moment. I wanted to know if you were making progress on the PR you just added but now it's clear:

#2998

Thank you!

@davwheat
Copy link
Member Author

I'll remove the translation file formatting before I merge.

@davwheat davwheat merged commit 906b0fb into main Feb 21, 2023
@davwheat davwheat deleted the dw/users-list/display-name branch February 21, 2023 13:04
@luceos luceos mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants