Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty suspension message uses email template expecting one #3433

Merged
merged 1 commit into from
May 26, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 20, 2022

Fixes #3417

Changes proposed in this pull request:
Adds a fallback message when the suspension message is empty.

Reviewers should focus on:
Do we want to do this or to introduce a new email template that simply does not expect a suspension message?

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 merged commit 29362ed into main May 26, 2022
@SychO9 SychO9 deleted the sm/3417-fallback-suspension-message branch May 26, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suspend] Empty suspension message produces an email notification with the template variable visible
3 participants