feat(seo): shift h1 tag from logo to discussion title #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many times have we seen opponents of using h2 as the discussion title. Although my own SEO knowledge is limited, I have seen the importance of structuring pages according to the content you wish to prioritize. If we only take that into consideration there is zero reason for the app-wide identical logo to take precedence over any other heading. This change makes the logo a standard (visually identical) element, and makes the discussion hero title a h1. Reviewers should focus on: - [ ] Do we want to do this (for 1.x)? - [ ] Do we need to make the logo element a different one?
SychO9
reviewed
Jan 22, 2023
|
Yeah I couldn't find a way to change this ti draft. Sorry. |
|
Looking at my code, it seems, making the change completely, does affect quite some rendered HTML. If we merge this for 1.7 (or 1.x in general) an entry for the Dev Upgrade Guide is required and a possible warning for end users to report issues related to it. |
SychO9
reviewed
Jan 22, 2023
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
I think we should keep our structure uniform across frontends. If we make the change it's easier to explain priority changed across all frontends instead of just one. |
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
SychO9
approved these changes
Feb 8, 2023
|
@rob006 please feel free to contribute the other changes you mention in another PR 🙏🏼. |
This was referenced Feb 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many times have we seen opponents of using h2 as the discussion title. Although my own SEO knowledge is limited, I have seen the importance of structuring pages according to the content you wish to prioritize. If we only take that into consideration there is zero reason for the app-wide identical logo to take precedence over any other heading.
Changes proposed in this pull request:
This change makes the logo a standard (visually identical) element, and makes the discussion hero title a h1.
Reviewers should focus on:
Necessity
Confirmed
composer test).Required changes: