feat(seo): Do not use h3 header for poster author in posts stream #3732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3724 (comment)
However this is more tricky, as some extensions rely on current markup. During brief testing I found 2 problems:
h3
tag:https://github.com/FriendsOfFlarum/gamification/blob/aad90d175fe55b3609de8c7649f9364765a37853/js/src/forum/components/RankingsPage.js#L76
This could be quite easily fixed in extension, but BC break is obvious and there could be more extensions affected by this change. If we want to keep BC here, I don't think there is other solution than postponing this change to 2.0.
In future it would be better to add CSS classes everywhere and discourage relying on markup, as used tag may always change. Even some basic cases like targeting link using
a
selector may be problematic, because in future this link may be changed to button instead.Necessity
Confirmed
composer test
).Required changes: