- fix phpdocs

- added cookies reference to php.net
- PageRequest::$url is now protected - the value is mandatory and should be used in constructor
- removed guzzle
- updated documentation

README.md

@@ -3,3 +3,14 @@
 A library to interact with the Phantom JS Cloud
 
 The library will generate the JSON Object. This object can be later sent as a HTTP Request with Guzzle or other HTTP Client for PHP.
+
+The library does not make HTTP requests - this library only generates the JSON you can use as a payload when you make your HTTP requests.
+
+### TODO - What we plan next for this code
+* find a general way to generate the JSON with out the NULL arguments
+* have a directory structure that will allow you to separate PhantomJS classes from helper classes
+* migrate public arguments to protected arguments where possible and use setters and getters.
+* integrate an HTTP client ( like GUZZLE HTTP )
+* add unit testing
+* see TODO's in the class comments
+* add examples in the documentation

composer.json

@@ -1,20 +1,19 @@
 {
-    "name": "cfv1000/phantomjs-cloud",
-    "description": "PhantomJS Cloud API based on Guzzle",
-    "type": "library",
-    "require": {
-        "guzzlehttp/guzzle": "^6.2"
-    },
-    "authors": [
-        {
-            "name": "Flaviu Chelaru",
-            "email": "flaviu.chelaru@gmail.com"
-        }
-    ],
-	"autoload": {
-		"psr-4": {
-			"PhantomJS\\" : "src/"
-		}
-	},
-    "minimum-stability": "stable"
+  "name": "cfv1000/phantomjs-cloud",
+  "description": "PhantomJS Cloud API based on Guzzle",
+  "type": "library",
+  "require": {
+  },
+  "authors": [
+    {
+      "name": "Flaviu Chelaru",
+      "email": "flaviu.chelaru@gmail.com"
+    }
+  ],
+  "autoload": {
+    "psr-4": {
+      "PhantomJS\\": "src/"
+    }
+  },
+  "minimum-stability": "stable"
 }

src/Cookie.php

@@ -3,6 +3,8 @@
 /**
  * Class Cookie
  * @package PhantomJS
+ *
+ * @see http://php.net/manual/ro/function.setcookie.php
  */
 class Cookie
 {

src/PageRequest.php

@@ -40,7 +40,7 @@ class PageRequest
      * required. the target page you wish to load
      * @var string
      */
-    public $url;
+    protected $url;
 
     /**
      * if specified, will be used as the content of the page you are loading (no network request will be made for the url).
@@ -74,7 +74,7 @@ class PageRequest
      *
      * @var string
      */
-    public $renderType;
+    public $renderType = self::RENDER_TYPE_JPEG;
 
     /**
      * adjustable parameters for when making network requests to the url specified

src/PageResponse.php

@@ -54,7 +54,7 @@ class PageResponse
     public $pageRequest;
 
     /**
-     * @var any
+     * @var
      */
     public $scriptOutput;
 

src/PdfHeaderFooter.php

@@ -10,7 +10,7 @@ class PdfHeaderFooter
 {
     /**
      * if specified, this is used for the first page (instead of the repeating)
-     * @var stringw
+     * @var string
      */
     public $firstPage;
 

src/PdfOptions.php

@@ -24,10 +24,11 @@ class PdfOptions
      * Border is optional and defaults to 0.
      * A non-uniform border can be specified in the form {left: '2cm', top: '2cm', right: '2cm', bottom: '3cm'}
      * Use of px is strongly recommended.
+     * TODO Build an object to represent the data
      *
      * @var int|array
      */
-    public $border;
+    public $border = 0;
 
     /**
      * set the DPI for pdf generation.

src/ProxyCustomOptions.php

@@ -27,7 +27,9 @@ class ProxyCustomOptions
     public $host;
 
     /**
-     * type of the proxy server. default is http available types are http, socks5, and none
+     * type of the proxy server.
+     * default is http
+     * available types are http, socks5, and none
      *
      * @var string
      */

src/RequestSettings.php

@@ -131,7 +131,7 @@ class RequestSettings
      *
      * @var int
      */
-    public $waitInterval;
+    public $waitInterval = 1000;
 
     /**
      * set to true to enable web security. default is false