-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add preview of images in Apps catalog (#815)
**Background** Currently int application users doesn't have an ability to preiew screenshots of hub applications. **Changes** - Created module screenshotspreview which allows to display preview images - Added module integration with modules inside faphub via callbacks **Test plan** 1. Open Hub->Apps 2. Wait until apps loaded and click on the image inside app item 3. Open app screen details and click on the image 4. Open Hub->Apps->Search and repeat the steps 2-3 from above
- Loading branch information
1 parent
34afaf5
commit 340d062
Showing
28 changed files
with
605 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
plugins { | ||
id("flipper.android-lib") | ||
id("kotlinx-serialization") | ||
} | ||
|
||
android.namespace = "com.flipperdevices.faphub.screenshotspreview.api" | ||
|
||
dependencies { | ||
implementation(projects.components.core.ui.decompose) | ||
implementation(libs.kotlin.immutable.collections) | ||
implementation(libs.decompose) | ||
} |
18 changes: 18 additions & 0 deletions
18
.../com/flipperdevices/faphub/screenshotspreview/api/ScreenshotsPreviewDecomposeComponent.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.flipperdevices.faphub.screenshotspreview.api | ||
|
||
import com.arkivanov.decompose.ComponentContext | ||
import com.flipperdevices.faphub.screenshotspreview.api.model.ScreenshotsPreviewParam | ||
import com.flipperdevices.ui.decompose.DecomposeOnBackParameter | ||
import com.flipperdevices.ui.decompose.ScreenDecomposeComponent | ||
|
||
abstract class ScreenshotsPreviewDecomposeComponent( | ||
componentContext: ComponentContext | ||
) : ScreenDecomposeComponent(componentContext) { | ||
fun interface Factory { | ||
operator fun invoke( | ||
componentContext: ComponentContext, | ||
param: ScreenshotsPreviewParam, | ||
onBack: DecomposeOnBackParameter, | ||
): ScreenshotsPreviewDecomposeComponent | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
.../kotlin/com/flipperdevices/faphub/screenshotspreview/api/model/ScreenshotsPreviewParam.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.flipperdevices.faphub.screenshotspreview.api.model | ||
|
||
import kotlinx.collections.immutable.ImmutableList | ||
import kotlinx.serialization.Serializable | ||
|
||
@Serializable | ||
/** | ||
* @param title name of catalog item | ||
* @param screenshotsUrls list of web-urls where screenshot available | ||
* @param selected index of selected [screenshotsUrls] item | ||
*/ | ||
data class ScreenshotsPreviewParam( | ||
val title: String, | ||
val screenshotsUrls: ImmutableList<String>, | ||
val selected: Int, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/build |
36 changes: 36 additions & 0 deletions
36
components/faphub/screenshotspreview/impl/build.gradle.kts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
plugins { | ||
id("flipper.android-compose") | ||
id("flipper.anvil") | ||
id("kotlinx-serialization") | ||
} | ||
|
||
android.namespace = "com.flipperdevices.faphub.screenshotspreview.impl" | ||
|
||
dependencies { | ||
implementation(projects.components.faphub.screenshotspreview.api) | ||
|
||
implementation(projects.components.core.share) | ||
|
||
implementation(projects.components.core.di) | ||
implementation(projects.components.core.log) | ||
implementation(projects.components.core.ktx) | ||
implementation(projects.components.core.ui.res) | ||
implementation(projects.components.core.ui.theme) | ||
implementation(projects.components.core.ui.ktx) | ||
implementation(projects.components.core.ui.decompose) | ||
implementation(projects.components.core.ui.lifecycle) | ||
|
||
// Compose | ||
implementation(libs.compose.ui) | ||
implementation(libs.compose.tooling) | ||
implementation(libs.compose.foundation) | ||
implementation(libs.compose.material) | ||
implementation(libs.lifecycle.viewmodel.ktx) | ||
implementation(libs.bundles.decompose) | ||
|
||
implementation(libs.zoomable) | ||
|
||
implementation(projects.components.faphub.appcard.composable) | ||
|
||
implementation(libs.kotlin.immutable.collections) | ||
} |
40 changes: 40 additions & 0 deletions
40
...rdevices/faphub/screenshotspreview/impl/api/FullScreenScreenshotDecomposeComponentImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package com.flipperdevices.faphub.screenshotspreview.impl.api | ||
|
||
import androidx.compose.runtime.Composable | ||
import com.arkivanov.decompose.ComponentContext | ||
import com.flipperdevices.core.di.AppGraph | ||
import com.flipperdevices.core.ui.lifecycle.viewModelWithFactory | ||
import com.flipperdevices.faphub.screenshotspreview.api.ScreenshotsPreviewDecomposeComponent | ||
import com.flipperdevices.faphub.screenshotspreview.api.model.ScreenshotsPreviewParam | ||
import com.flipperdevices.faphub.screenshotspreview.impl.composable.ComposableFullScreenshotScreen | ||
import com.flipperdevices.faphub.screenshotspreview.impl.viewmodel.UrlImageShareViewModel | ||
import com.flipperdevices.ui.decompose.DecomposeOnBackParameter | ||
import dagger.assisted.Assisted | ||
import dagger.assisted.AssistedInject | ||
import me.gulya.anvil.assisted.ContributesAssistedFactory | ||
import javax.inject.Provider | ||
|
||
@ContributesAssistedFactory(AppGraph::class, ScreenshotsPreviewDecomposeComponent.Factory::class) | ||
class FullScreenScreenshotDecomposeComponentImpl @AssistedInject constructor( | ||
@Assisted componentContext: ComponentContext, | ||
@Assisted private val param: ScreenshotsPreviewParam, | ||
@Assisted private val onBack: DecomposeOnBackParameter, | ||
private val urlImageShareViewModelProvider: Provider<UrlImageShareViewModel>, | ||
) : ScreenshotsPreviewDecomposeComponent(componentContext) { | ||
|
||
@Composable | ||
@Suppress("NonSkippableComposable") | ||
override fun Render() { | ||
val urlImageShareViewModel = viewModelWithFactory(null) { | ||
urlImageShareViewModelProvider.get() | ||
} | ||
|
||
ComposableFullScreenshotScreen( | ||
urlImageShareViewModel = urlImageShareViewModel, | ||
onBack = onBack::invoke, | ||
title = param.title, | ||
selected = param.selected, | ||
screenshots = param.screenshotsUrls | ||
) | ||
} | ||
} |
83 changes: 83 additions & 0 deletions
83
...lipperdevices/faphub/screenshotspreview/impl/composable/ComposableFullScreenshotScreen.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
package com.flipperdevices.faphub.screenshotspreview.impl.composable | ||
|
||
import androidx.compose.foundation.layout.Box | ||
import androidx.compose.foundation.layout.fillMaxSize | ||
import androidx.compose.foundation.layout.navigationBarsPadding | ||
import androidx.compose.foundation.pager.rememberPagerState | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Alignment | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.platform.LocalContext | ||
import androidx.compose.ui.tooling.preview.Preview | ||
import com.flipperdevices.core.ui.theme.FlipperThemeInternal | ||
import com.flipperdevices.faphub.screenshotspreview.impl.composable.content.ComposableFullScreenshotAppBar | ||
import com.flipperdevices.faphub.screenshotspreview.impl.composable.content.ComposableScreenshotsList | ||
import com.flipperdevices.faphub.screenshotspreview.impl.composable.content.ComposableScreenshotsPager | ||
import com.flipperdevices.faphub.screenshotspreview.impl.viewmodel.UrlImageShareViewModel | ||
import kotlinx.collections.immutable.ImmutableList | ||
import kotlinx.collections.immutable.toPersistentList | ||
import java.net.URL | ||
|
||
@Composable | ||
internal fun ComposableFullScreenshotScreen( | ||
onBack: () -> Unit, | ||
title: String, | ||
selected: Int, | ||
screenshots: ImmutableList<String>, | ||
urlImageShareViewModel: UrlImageShareViewModel | ||
) { | ||
val pagerState = rememberPagerState(selected) { | ||
screenshots.size | ||
} | ||
|
||
Box( | ||
modifier = Modifier | ||
.fillMaxSize() | ||
.navigationBarsPadding(), | ||
contentAlignment = Alignment.Center | ||
) { | ||
ComposableScreenshotsPager( | ||
screenshots = screenshots, | ||
pagerState = pagerState, | ||
modifier = Modifier | ||
.fillMaxSize() | ||
.align(Alignment.Center) | ||
) | ||
|
||
ComposableScreenshotsList( | ||
screenshots = screenshots, | ||
pagerState = pagerState, | ||
modifier = Modifier.align(Alignment.BottomCenter) | ||
) | ||
|
||
ComposableFullScreenshotAppBar( | ||
onBack = onBack, | ||
title = title, | ||
itemsAmount = screenshots.size, | ||
selectedItemIndex = pagerState.currentPage, | ||
modifier = Modifier.align(Alignment.TopCenter), | ||
onSaveClicked = { | ||
val url = screenshots[pagerState.currentPage].let(::URL) | ||
urlImageShareViewModel.shareUrlImage(url) | ||
} | ||
) | ||
} | ||
} | ||
|
||
@Preview(showBackground = true) | ||
@Composable | ||
private fun FullScreenshotScreenPreview() { | ||
FlipperThemeInternal { | ||
ComposableFullScreenshotScreen( | ||
onBack = {}, | ||
screenshots = List(size = 20) { | ||
"https://catalog.flipperzero.one/api/v0/application/version/assets/660e569e6c9840814200ecb8" | ||
}.toPersistentList(), | ||
title = "Snake game", | ||
selected = 3, | ||
urlImageShareViewModel = UrlImageShareViewModel( | ||
applicationContext = LocalContext.current.applicationContext | ||
) | ||
) | ||
} | ||
} |
Oops, something went wrong.