Add preview of images in Apps catalog #815
Conversation
| @@ -250,6 +250,8 @@ decompose-jetpack = { module = "com.arkivanov.decompose:extensions-compose", ver | |||
| essenty-lifecycle = { module = "com.arkivanov.essenty:lifecycle", version.ref = "essenty" } | |||
| essenty-lifecycle-coroutines = { module = "com.arkivanov.essenty:lifecycle-coroutines", version.ref = "essenty" } | |||
|
|
|||
| zoomable = { module = "net.engawapg.lib:zoomable", version.ref = "zoomable" } | |||
There was a problem hiding this comment.
The library looks good, updating with bot, have Modifier.Node api. In case of KMP we can create PR to add it's support later
| @@ -12,7 +13,8 @@ abstract class BottomBarDecomposeComponent<C : Any> : CompositeDecomposeComponen | |||
| operator fun invoke( | |||
| componentContext: ComponentContext, | |||
| onBack: DecomposeOnBackParameter, | |||
| deeplink: Deeplink.BottomBar? | |||
| deeplink: Deeplink.BottomBar?, | |||
| screenshotsClickListener: ScreenshotsClickListener | |||
There was a problem hiding this comment.
There's overall "little bit" callback hell right now. But even deeplinks will be required inside AssistedFactories
There was a problem hiding this comment.
I think you should use LocalRootNavigation in this case. Could you, please, check this?
There was a problem hiding this comment.
Replaced with LocalRootNavigation
| screenshots: ImmutableList<String>, | ||
| urlImageShareViewModel: UrlImageShareViewModel | ||
| ) { | ||
| val itemsAmount = remember { screenshots.size } |
There was a problem hiding this comment.
Are you sure that current keys in remember is correct? Maybe use screenshots as key?
Also i'm not sure if it's really necessary to use remember here. Can you check?
There was a problem hiding this comment.
Previously there was different chunk of code. Indeed in ImmutableList the size is set at init and can't be changed after. So it's useless now
| .size(24.dp) | ||
| .clickableRipple(bounded = false, onClick = onBack), | ||
| painter = painterResource(DesignSystem.drawable.ic_back), | ||
| contentDescription = null.orEmpty() |
There was a problem hiding this comment.
Added contentDescription
...kotlin/com/flipperdevices/faphub/screenshotspreview/impl/viewmodel/UrlImageShareViewModel.kt
Show resolved
Hide resolved
| private fun Bitmap.fillBackground(): Bitmap { | ||
| val newBitmap = Bitmap.createBitmap(width, height, config) | ||
| val canvas = Canvas(newBitmap) | ||
| canvas.drawColor(Color.rgb(ACCENT_COLOR_R, ACCENT_COLOR_G, ACCENT_COLOR_B)) |
There was a problem hiding this comment.
Maybe reuse the colour from other place?
There was a problem hiding this comment.
Replaced with accent color from DesignSystem
Background
Currently int application users doesn't have an ability to preiew screenshots of hub applications.
Changes
Test plan