Align graceful-shutdown-timeout with terminationGracePeriodSeconds #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the default value for the graceful-shutdown-timeout flag to match the default terminationGracePeriodSeconds value we set for the controller pod container. It seems the controller-runtime does not support passing -1 as a value to skip the timeout as documented here: https://github.com/kubernetes-sigs/controller-runtime/blob/v0.13.1/pkg/manager/manager.go#L286 Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
|
@relu to fix the e2e tests please do this fluxcd/flux2@21a943e |
Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
stefanprodan
approved these changes
Dec 22, 2022
|
We also need to update the options.md in website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the default value for the graceful-shutdown-timeout flag to match the default terminationGracePeriodSeconds value we set for the controller pod container.
It seems the controller-runtime does not support passing -1 as a value to skip the timeout as documented here:
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.13.1/pkg/manager/manager.go#L286
With this change, it would also make sense to update the documentation to add a new section about graceful shutdown and explain the relation between these two values and also related to how the readiness probe affects graceful shutdown.