Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align graceful-shutdown-timeout with terminationGracePeriodSeconds #584

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Align graceful-shutdown-timeout with terminationGracePeriodSeconds #584

merged 2 commits into from
Dec 22, 2022

Commits on Dec 21, 2022

  1. Align graceful-shutdown-timeout with terminationGracePeriodSeconds 

    Setting the default value for the graceful-shutdown-timeout flag to
match the default terminationGracePeriodSeconds value we set for the
controller pod container.
It seems the controller-runtime does not support passing -1 as a value
to skip the timeout as documented here:
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.13.1/pkg/manager/manager.go#L286

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
    @relu
    relu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d2b52de View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. e2e: Update Kubernetes to v1.23.13 

    Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
    @relu
    relu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9875909 View commit details
    Browse the repository at this point in the history