Add Access Control List API types and conditions #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
reviewed
Aug 9, 2021
| // These constants define the Condition reasons for when the GitOps Toolkit components perform ACL assertions. | ||
| const ( | ||
| // AccessDeniedReason indicates that access to a resource has been denied by an ACL assertion. | ||
| AccessDeniedReason string = "AccessDenied" |
There was a problem hiding this comment.
Would there be more context defining / informative reasons for when the Condition type is AccessDenied?
There was a problem hiding this comment.
Not right now, as our ACL is based on namespace labels only, but if we add more matches, such as caller labels, then we could have 2 different reasons.
There was a problem hiding this comment.
Note that I've added here the reason so that it gets copied to Ready, as our helpers doesn't copy the condition type to the Ready reason.
hiddeco
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fluxcd/flux2#1704