Add ACL authorization helper to runtime #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
the
area/runtime
hiddeco
reviewed
Aug 9, 2021
stefanprodan
force-pushed
the
runtime-acl
branch
from
6e058a6
to
ff95106
Compare
hiddeco
reviewed
Aug 10, 2021
stefanprodan
force-pushed
the
runtime-acl
branch
from
ff95106
to
a488648
Compare
hiddeco
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
One last remark on the new doc-block, but other than that LGTM. Thank you @stefanprodan 💯
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
runtime-acl
branch
from
a488648
to
4ee2705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fluxcd/flux2#1704