Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard more system headers by FMT_MODULE #4006

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

yujincheng08
Copy link
Contributor

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think we should use a single macro to make this cleaner when possible, e.g. FMT_MODULE (and set it if FMT_IMPORT_STD is defined).

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good, just minor comments inline.

include/fmt/base.h Outdated Show resolved Hide resolved
include/fmt/format-inl.h Outdated Show resolved Hide resolved
include/fmt/format-inl.h Outdated Show resolved Hide resolved
@vitaut vitaut merged commit 8687315 into fmtlib:master Jun 14, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jun 14, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants