Add Style CornerLength #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
force-pushed
the
js/handle-length
branch
from
303db98
to
f74a5e0
Compare
|
This is just a rebase of the commit to current main. I haven't tried to fix the issues as I don't understand how the states are saved/restored. |
somiaj
force-pushed
the
js/handle-length
branch
5 times, most recently
from
c33c9ff
to
ec3e2e8
Compare
Adds a style to set the length of the corners of a window. This style takes a single numerical argument and sets the length of the corner in number of pixels beyond the edge of the boundary. If the argument has a '%' suffix, the number will be treated as a percent of the window size instead of a pixel length. Note: Corner percent flag is stored as a negative value, due to not being able to get flag states to work correctly.
somiaj
force-pushed
the
js/handle-length
branch
from
ec3e2e8
to
ebe89e3
Compare
Merged
|
Closing in favor of #928. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a style to set the length of the corners of a window. This style
takes a single numerical argument and sets the length of the corner
in number of pixels beyond the edge of the boundary. If the argument
has a '%' suffix, the number will be treated as a percent of the window
size instead of a pixel length.
@ThomasAdam I can't seem to get the
Style * CornerLength 25%to work consistently. Two issues, first is the flaghas_corner_percentis just ignored unless you issue aStyle * BorderLength 5command first, afterwards, the flag will be honored (if you issue the command again). But if you change any style such asBorderWidth,HandleWidth,!Handles, the flag is lost, and you need to runStyle * CornerLength 25%again. In short I'm having trouble setting theuse_corner_percentflag so that it correctly gets used and doesn't get reset, though it does work in some cases just fine.