Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style CornerLength #928

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Add Style CornerLength #928

merged 2 commits into from
Dec 3, 2023

Conversation

somiaj
Copy link
Collaborator

@somiaj somiaj commented Dec 2, 2023

Renames the window setting variable corner_width as corner_length, since length is more descriptive of what does, and make this configurable (currently it is computed using the title height and border thickness). The corner_length of a window can be configured using the new CornerLength style, which takes a single numerical argument as the length in pixels. If no argument (or an invalid argument) is provided, the default is used, which is the title height.

This is a rework of #771 that only allows pixel settings (since there were some issues with the % setting option).

  Renames the window setting variable corner_width as corner_length,
  since length is more descriptive of what does, and make this
  configurable (currently it is computed using the title height and
  border thickness). The corner_length of a window can be configured
  using the new CornerLength style, which takes a single numerical
  argument as the length in pixels. If no argument (or an invalid
  argument) is provided, the default is used, which is the title
  height.
@somiaj somiaj mentioned this pull request Dec 2, 2023
@ThomasAdam ThomasAdam added the type:enhancement Augmenting an existing feature label Dec 2, 2023
@ThomasAdam ThomasAdam added this to the 1.0.9 milestone Dec 2, 2023
Remove an assignment which was never used.
@ThomasAdam ThomasAdam self-assigned this Dec 3, 2023
@ThomasAdam ThomasAdam merged commit e4da63f into main Dec 3, 2023
5 checks passed
@ThomasAdam ThomasAdam deleted the js/corner-length branch December 3, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Augmenting an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants