Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object selector to the shoot webhook #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add object selector to the shoot webhook #988

wants to merge 1 commit into from

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jun 24, 2024 •
edited
Loading

How to categorize this PR?

/area scalability
/kind enhancement
/platform aws

What this PR does / why we need it:
Add object selector to the shoot webhook so that it is not invoked on every ConfigMap CREATE/UPDATE request in the kube-system namespace in the Shoot but only for the addons-nginx-ingress-controller ConfigMap.

Which issue(s) this PR fixes:
Part of gardener/gardener#9864

Special notes for your reviewer:
N/A

Release note:

The shoot-webhook that mutates the `addons-nginx-ingress-controller` ConfigMap does now specify object selector. The webhook will now intercept only requests for the `addons-nginx-ingress-controller` ConfigMap.

@gardener-robot gardener-robot added area/scalability Scalability related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 24, 2024
This was referenced Jun 25, 2024
Merged
Open
Merged
Merged
Draft
@ialidzhikov ialidzhikov force-pushed the enh/shoot-webhook-object-selector branch from fadc672 to dcb524b Compare August 15, 2024 09:03
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review August 15, 2024 09:04
@ialidzhikov ialidzhikov requested review from a team as code owners August 15, 2024 09:04
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2024
@ialidzhikov ialidzhikov force-pushed the enh/shoot-webhook-object-selector branch from dcb524b to 502768b Compare August 27, 2024 08:38
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 27, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot