Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shoot webhook: Clean up obsolete mutation and add object selector #316

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

shoot webhook: Clean up obsolete mutation and add object selector #316

wants to merge 3 commits into from

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area scalability
/kind enhancement
/platform equinix-metal

What this PR does / why we need it:
1st commit: After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.

3th commit: Similar to gardener/gardener-extension-provider-aws#988

Which issue(s) this PR fixes:
Part of gardener/gardener#9864

Special notes for your reviewer:
N/A

Release note:

The shoot-webhook does no longer mutate the metrics-server Deployment. The shoot-webhook that now only mutates the `vpn-shoot` Deployment does now specify object selector.

@ialidzhikov
Drop obsolete code for the metrics-server Deployment mutation
ce2636e 
After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
@ialidzhikov
[drop me] Replace gardener dependency with github.com/ialidzhikov/gar…
dab2f25 
…dener@575ab37a4733d7c85600e8be148e19b73d1afa9b
@ialidzhikov
Add object selector to the shoot webhook
caadc50
@gardener-robot gardener-robot added area/scalability Scalability related kind/enhancement Enhancement, improvement, extension platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 25, 2024
@ialidzhikov ialidzhikov mentioned this pull request Jun 25, 2024
Open
17 tasks
@ialidzhikov ialidzhikov changed the title Enh/shoot webhook object selector shoot webhook: Clean up obsolete mutation and add object selector Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrodit schrodit Awaiting requested review from schrodit schrodit will be requested when the pull request is marked ready for review schrodit is a code owner

@jonas-zipprick jonas-zipprick Awaiting requested review from jonas-zipprick jonas-zipprick will be requested when the pull request is marked ready for review jonas-zipprick is a code owner

@RiRa12621 RiRa12621 Awaiting requested review from RiRa12621 RiRa12621 will be requested when the pull request is marked ready for review RiRa12621 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/review Needs review needs/second-opinion Needs second review by someone else platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ialidzhikov @gardener-robot