Fix metrics-server lookup order #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vasu1124 <vasu1124@actvirtual.com>
gardener-robot
added
area/control-plane
rfranzke
reviewed
Oct 21, 2021
There was a problem hiding this comment.
/cc @vpnachev @timuthy @MartinWeindel @jia-jerry
Any concerns/comments?
vpnachev
approved these changes
Oct 21, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
Signed-off-by: vasu1124 <vasu1124@actvirtual.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
Signed-off-by: vasu1124 <vasu1124@actvirtual.com>
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-alicloud
that referenced
this pull request
Jun 25, 2024
After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-packet
that referenced
this pull request
Jun 25, 2024
After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-alicloud
that referenced
this pull request
Sep 9, 2024
After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-alicloud
that referenced
this pull request
Sep 9, 2024
After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
kevin-lacoo
pushed a commit
to gardener/gardener-extension-provider-alicloud
that referenced
this pull request
Sep 18, 2024
) * Drop obsolete code for the vpn-shoot Service mutation After ReversedVPN feature is unconditionally enabled, there is no longer a Service kube-system/vpn-shoot in the Shoot cluster * Drop obsolete code for the metrics-server Deployment mutation After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment. * Add object selector to the shoot webhook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vasu1124 vasu1124@actvirtual.com
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
The metrics-server with the current rule will always use
Hostnameto resolve the scraping target. TheHostnamecan only be resolved in infrastructure environments where automatically DNS entries are provisioned. In many environments, like OpenStack, metal, equinix, etc. there is no such DNS entry.The setting ensures that the metric-server picks one of the keys (type in the given rule order) from the
noderesource, e.g.The
type: Hostnamewill always be available (no node w/o hostname!), but is not always resolveable. Hence, the metric-server in such cases will always fail to scrape the node.This PR fixes the rule to choose
InternalIPfirst, which should be a correct selection for allmost all environments, and skip to other the alternatives only if that type is not set:InternalIP,InternalDNS,ExternalDNS,ExternalIP,HostnameWhich issue(s) this PR fixes:
Fixes #4626 #2455 #2019 and probably more
Special notes for your reviewer:
We have been arguing over this rule change over many issues (overlayed by a notation/typo fix with/without bracket).
The proposed rule should be safe. But please run via test matrix.
Release note: