Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

! Field/Binding is read-only (Actions failing) #1111

Closed
Nowosad opened this issue Sep 19, 2024 · 5 comments · Fixed by #1117
Closed

! Field/Binding is read-only (Actions failing) #1111

Nowosad opened this issue Sep 19, 2024 · 5 comments · Fixed by #1117
Assignees
@jannes-m

Comments

@Nowosad
Copy link
Member

Nowosad commented Sep 19, 2024

@jannes-m -- sorry for bothering you, but the GHA is failing in ch12: https://github.com/geocompx/geocompr/actions/runs/10936378995/job/30359901540. Could you take a look at it?
@Robinlovelace Robinlovelace mentioned this issue Sep 20, 2024
Closed
@Nowosad Nowosad changed the title ! Field/Binding is read-only ! Field/Binding is read-only (Actions failing) Sep 20, 2024
Robinlovelace added a commit that referenced this issue Sep 24, 2024
@Robinlovelace
Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)
b402780
@Robinlovelace Robinlovelace linked a pull request Sep 24, 2024 that will close this issue
Do not evaluate failing mlr3::lrn chunk (#1111 hotfix) #1117
Merged
@jannes-m
Copy link
Collaborator

I am a bit baffled, running this in our docker container, the error is not occurring. The only difference for now is that I have used remotes::install_github("mlr-org/mlr3extralearners@v0.9.0").

@jannes-m
Copy link
Collaborator

Looking at https://github.com/geocompx/geocompr/blob/main/.github/workflows/main.yaml (here, we install geocompkg), I would suggest to use remotes::install_github("mlr-org/mlr3extralearners@v0.9.0") there also for the moment.

@Robinlovelace
Copy link
Collaborator

FYI it seems that our Docker images, that build the book with Actions, do not ship with the dev versions of tmap, and maybe other packages. So could be upstream Docker issue?

geocompx/docker#75

Any help with that appreciated.

Robinlovelace added a commit that referenced this issue Sep 25, 2024
@Robinlovelace
Merge pull request #1117 from geocompx/1111-fieldbinding-is-read-only…
d067f36 
…-actions-failing

Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)
github-actions bot pushed a commit that referenced this issue Sep 25, 2024
@Robinlovelace
Deploy commit: Merge pull request #1117 from geocompx/1111-fieldbindi…
510381a 
…ng-is-read-only-actions-failing

Do not evaluate failing mlr3::lrn chunk (#1111 hotfix) d067f36
@Robinlovelace
Copy link
Collaborator

Should probably keep this open until the non-evaluated chunks are evaluated again.

See here for the changes, some of which may no longer be necessary after geocompx/geocompkg#45 was merged:

https://github.com/geocompx/geocompr/pull/1117/files

@Robinlovelace Robinlovelace reopened this Sep 25, 2024
jannes-m added a commit that referenced this issue Sep 25, 2024
@jannes-m
Revert "Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)"
4018200 
This reverts commit b402780.
@jannes-m jannes-m mentioned this issue Sep 25, 2024
Merged
Robinlovelace pushed a commit that referenced this issue Sep 25, 2024
@jannes-m
Revert ml stuff (#1124)
bfb40b7 
* Revert "eval=FALSE in c15"

This reverts commit 80872c3.

* Revert "store_backends"

This reverts commit e6f74bd.

* Revert "Remove cache from chunk 15-eco-26"

This reverts commit 7217843.

* Revert "Try evaluating train function"

This reverts commit 6302bc7.

* Revert "Update 15-tune.rds, fix actions (hopefully)"

This reverts commit 737cbfc.

* Revert "Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)"

This reverts commit b402780.

* set eval=TRUE and save 15-tune.rds anew

* use new method of specifying a fallback learner (breaking change, see https://github.com/mlr-org/mlr3/releases/tag/v0.21.0)

* rebuild the autotuner
github-actions bot pushed a commit that referenced this issue Sep 25, 2024
@Robinlovelace
Deploy commit: Revert ml stuff (#1124)
870ea0c 
* Revert "eval=FALSE in c15"

This reverts commit 80872c3.

* Revert "store_backends"

This reverts commit e6f74bd.

* Revert "Remove cache from chunk 15-eco-26"

This reverts commit 7217843.

* Revert "Try evaluating train function"

This reverts commit 6302bc7.

* Revert "Update 15-tune.rds, fix actions (hopefully)"

This reverts commit 737cbfc.

* Revert "Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)"

This reverts commit b402780.

* set eval=TRUE and save 15-tune.rds anew

* use new method of specifying a fallback learner (breaking change, see https://github.com/mlr-org/mlr3/releases/tag/v0.21.0)

* rebuild the autotuner bfb40b7
@jannes-m
Copy link
Collaborator

closed via #1124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannes-m jannes-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not evaluate failing mlr3::lrn chunk (#1111 hotfix) geocompx/geocompr
3 participants
@Robinlovelace @Nowosad @jannes-m