Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ml stuff #1124

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Revert ml stuff #1124

merged 9 commits into from
Sep 25, 2024

Conversation

jannes-m
Copy link
Collaborator

No description provided.

@jannes-m
Copy link
Collaborator Author

In the latest mlr3 version is a breaking change (https://github.com/mlr-org/mlr3/releases/tag/v0.21.0) how fallback learners are defined (see also #1111). I have addressed this, let's what comes next -:)

Copy link
Collaborator

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge after actions passing.

15-eco.Rmd Show resolved Hide resolved
@Robinlovelace
Copy link
Collaborator

Great job, thanks Jannes, will merge!

@Robinlovelace Robinlovelace merged commit bfb40b7 into main Sep 25, 2024
3 checks passed
@Robinlovelace Robinlovelace deleted the revert_ml_stuff branch September 25, 2024 13:00
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
* Revert "eval=FALSE in c15"

This reverts commit 80872c3.

* Revert "store_backends"

This reverts commit e6f74bd.

* Revert "Remove cache from chunk 15-eco-26"

This reverts commit 7217843.

* Revert "Try evaluating train function"

This reverts commit 6302bc7.

* Revert "Update 15-tune.rds, fix actions (hopefully)"

This reverts commit 737cbfc.

* Revert "Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)"

This reverts commit b402780.

* set eval=TRUE and save 15-tune.rds anew

* use new method of specifying a fallback learner (breaking change, see https://github.com/mlr-org/mlr3/releases/tag/v0.21.0)

* rebuild the autotuner bfb40b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants