fix: define separate module names for UIKitless configurations

[armcknight]

Define a different module name for the configurations that build without UIKit enabled. Ideally we split out a separate submodule for UIKit stuff a la #3219, but this is a workaround in the meantime.

Had to fix an issue with the test targets' configuration. They included Sentry.xcconfig and so inherited the module names. But, they never should have inherited from that config. It looks like they overrode everything anyways, except for the workaround using HEADER_SEARCH_PATHS.

fixes ##4086

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.348%. Comparing base (d26797f) to head (9ad35df).

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4140       +/-   ##
=============================================
- Coverage   91.357%   91.348%   -0.009%     
=============================================
  Files          604       604               
  Lines        48179     48179               
  Branches     17355     17352        -3     
=============================================
- Hits         44015     44011        -4     
- Misses        4071      4075        +4     
  Partials        93        93               

see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26797f...9ad35df. Read the comment docs.

[aaronsky]

Try this @armcknight

asky-1.patch

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1241.47 ms	1258.00 ms	16.53 ms
Size	21.58 KiB	682.40 KiB	660.82 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
e681215	6240.94 ms	6254.36 ms	13.42 ms
a71f5e2	1239.92 ms	1250.67 ms	10.76 ms
51307b7	1223.08 ms	1240.76 ms	17.68 ms
984eb2d	1220.62 ms	1235.24 ms	14.62 ms
3437454	1254.04 ms	1259.50 ms	5.46 ms
becc941	1221.90 ms	1240.37 ms	18.47 ms
7bc3c0d	1212.35 ms	1228.94 ms	16.59 ms
7bb0873	1215.65 ms	1235.00 ms	19.35 ms
f587451	1271.63 ms	1275.90 ms	4.27 ms
6e31b7c	1230.80 ms	1246.29 ms	15.49 ms

App size

Revision	Plain	With Sentry	Diff
e681215	20.76 KiB	431.91 KiB	411.15 KiB
a71f5e2	21.58 KiB	424.34 KiB	402.76 KiB
51307b7	22.85 KiB	407.63 KiB	384.78 KiB
984eb2d	20.76 KiB	425.77 KiB	405.01 KiB
3437454	22.85 KiB	408.87 KiB	386.02 KiB
becc941	21.58 KiB	419.82 KiB	398.24 KiB
7bc3c0d	20.76 KiB	427.35 KiB	406.59 KiB
7bb0873	22.85 KiB	407.09 KiB	384.24 KiB
f587451	20.76 KiB	435.25 KiB	414.49 KiB
6e31b7c	21.58 KiB	614.65 KiB	593.07 KiB

Previous results on branch: armcknight/fix/module-names

Startup times

Revision	Plain	With Sentry	Diff
1d5b5f7	1239.52 ms	1255.79 ms	16.27 ms
e1f6a1a	1218.40 ms	1231.88 ms	13.48 ms

App size

Revision	Plain	With Sentry	Diff
1d5b5f7	21.58 KiB	682.39 KiB	660.81 KiB
e1f6a1a	21.58 KiB	682.12 KiB	660.54 KiB

[brustolin]

Thanks for this @armcknight !!

All looks good.