-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: define separate module names for UIKitless configurations #4140
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c1b08f - Browse repository at this point
Copy the full SHA 6c1b08fView commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d77c11 - Browse repository at this point
Copy the full SHA 5d77c11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f510f3 - Browse repository at this point
Copy the full SHA 8f510f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d509ee6 - Browse repository at this point
Copy the full SHA d509ee6View commit details -
- also configure product name and bundle ID - rename Debug_without_UIKit and Release_without_UIKit to remove the underscores and capitalize "without" - add a separate modulemap file for SentryWithoutUIKit
Configuration menu - View commit details
-
Copy full SHA for e58a5f5 - Browse repository at this point
Copy the full SHA e58a5f5View commit details -
rename _SentryPrivate to _SentryWithoutUIKitPrivate in module.modulemap
fixes this error: Module 'SentryWithoutUIKit' in AST file '/Users/andrewmcknight/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/22JF8W0XJRMRE/SentryWithoutUIKit-1Z1Q6V1DCHSHF.pcm' (imported by AST file '/Users/andrewmcknight/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/22JF8W0XJRMRE/_SentryPrivate-23Z4ZY3NE0LI4.pcm') is not defined in any loaded module map file; maybe you need to load '/Users/andrewmcknight/Library/Developer/Xcode/DerivedData/Sentry-gnnqqmcfqpqmmhcjxfzwadgjajnt/Build/Products/DebugWithoutUIKit-iphonesimulator/Sentry.framework/Modules/module.modulemap'? we probably need to rename this from module.modulemap to SentryWithoutUIKitPrivate.modulemap and create the parallel SentryPrivate.modulemap and set those as MODULEMAP_PRIVATE_FILE per config
Configuration menu - View commit details
-
Copy full SHA for 4cd970d - Browse repository at this point
Copy the full SHA 4cd970dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9128272 - Browse repository at this point
Copy the full SHA 9128272View commit details -
Configuration menu - View commit details
-
Copy full SHA for e133b18 - Browse repository at this point
Copy the full SHA e133b18View commit details -
Configuration menu - View commit details
-
Copy full SHA for d63a893 - Browse repository at this point
Copy the full SHA d63a893View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2a7ca - Browse repository at this point
Copy the full SHA 1b2a7caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 623274d - Browse repository at this point
Copy the full SHA 623274dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bcec49 - Browse repository at this point
Copy the full SHA 0bcec49View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2da7e3 - Browse repository at this point
Copy the full SHA c2da7e3View commit details -
make uikit linkage more strict, because now we have a match for UIKit…
….framework in @rpath/SentryWithoutUIKit.framework/SentryWithoutUIKit
Configuration menu - View commit details
-
Copy full SHA for 0cb91fb - Browse repository at this point
Copy the full SHA 0cb91fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 392e62a - Browse repository at this point
Copy the full SHA 392e62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f93f597 - Browse repository at this point
Copy the full SHA f93f597View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6cb350 - Browse repository at this point
Copy the full SHA d6cb350View commit details -
try using an include test to fix a downstream issue with my bazel build
the error starts out as such: ERROR: /Users/andrewmcknight/Code/organization/getsentry/repos/public/sentry-cocoa-bazel/file_provider_extension/BUILD:4:14: Compiling Swift module //file_provider_extension:file_provider_swift_sources failed: (Exit 1): worker failed: error executing SwiftCompile command (from target //file_provider_extension:file_provider_swift_sources) bazel-out/darwin_arm64-opt-exec-ST-13d3ddad9198/bin/external/build_bazel_rules_swift/tools/worker/worker swiftc ... (remaining 1 argument skipped) error: emit-module command failed with exit code 1 (use -v to see invocation) <module-includes>:2:9: note: in file included from <module-includes>:2: ^ vendor/Carthage/Build/SentryWithoutUIKit.xcframework/ios-arm64_x86_64-simulator/SentryWithoutUIKit.framework/Headers/SentryWithoutUIKit-Swift.h:324:29: error: cannot find protocol declaration for 'SentrySerializable' @protocol SentryRRWebEvent <SentrySerializable> ^ <module-includes>:2:9: note: in file included from <module-includes>:2: ^ vendor/Carthage/Build/SentryWithoutUIKit.xcframework/ios-arm64_x86_64-simulator/SentryWithoutUIKit.framework/Headers/SentryWithoutUIKit-Swift.h:640:32: error: cannot find interface declaration for 'SentryEvent', superclass of 'SentryReplayEvent' @interface SentryReplayEvent : SentryEvent ^ <module-includes>:1:9: note: in file included from <module-includes>:1: ^ /private/var/tmp/_bazel_andrewmcknight/1473e8b1ae382f4a9a68831aec4e0587/execroot/_main/vendor/Carthage/Build/SentryWithoutUIKit.xcframework/ios-arm64_x86_64-simulator/SentryWithoutUIKit.framework/Headers/SentryWithoutUIKit.h:50:1: warning: umbrella header for module 'SentryWithoutUIKit' does not include header 'SentryMeasurementUnit.h' ^ <module-includes>:1:9: note: in file included from <module-includes>:1: ^ /private/var/tmp/_bazel_andrewmcknight/1473e8b1ae382f4a9a68831aec4e0587/execroot/_main/vendor/Carthage/Build/SentryWithoutUIKit.xcframework/ios-arm64_x86_64-simulator/SentryWithoutUIKit.framework/Headers/SentryWithoutUIKit.h:50:1: warning: umbrella header for module 'SentryWithoutUIKit' does not include header 'SentryNSError.h'
Configuration menu - View commit details
-
Copy full SHA for 15aeae1 - Browse repository at this point
Copy the full SHA 15aeae1View commit details
Commits on Jul 3, 2024
-
fix xcframework script that fails to find the artifacts correctly aft…
…er module name change
Configuration menu - View commit details
-
Copy full SHA for 72f2ae5 - Browse repository at this point
Copy the full SHA 72f2ae5View commit details
Commits on Jul 8, 2024
-
also use the check for available header instead of user defined setti…
…ng in Swift.h umbrella header
Configuration menu - View commit details
-
Copy full SHA for d15d002 - Browse repository at this point
Copy the full SHA d15d002View commit details -
fixup! also use the check for available header instead of user define…
…d setting in Swift.h umbrella header
Configuration menu - View commit details
-
Copy full SHA for 526adf5 - Browse repository at this point
Copy the full SHA 526adf5View commit details -
fixup! fixup! also use the check for available header instead of user…
… defined setting in Swift.h umbrella header
Configuration menu - View commit details
-
Copy full SHA for ea61def - Browse repository at this point
Copy the full SHA ea61defView commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8728da2 - Browse repository at this point
Copy the full SHA 8728da2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f772a63 - Browse repository at this point
Copy the full SHA f772a63View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f125f - Browse repository at this point
Copy the full SHA a6f125fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a25a487 - Browse repository at this point
Copy the full SHA a25a487View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ad35df - Browse repository at this point
Copy the full SHA 9ad35dfView commit details