Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling in POtel #3318

Closed
sl0thentr0py opened this issue Jul 22, 2024 · 0 comments · Fixed by #3501
Closed

Sampling in POtel #3318

sl0thentr0py opened this issue Jul 22, 2024 · 0 comments · Fixed by #3501
Assignees
@antonpirker
Labels
Integration: OpenTelementry (OTel) Project: POTel (Phase 1)
Milestone
Performance power...

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Jul 22, 2024 •
edited by antonpirker
Loading

Sample Opentelemetry spans according to the configuration options traces_sampler and traces_sample_rate also take incoming requests into account (upstreams sampling decision or if the upstream service has deferred the sampling decision)

Also think about: Sentry's sampling is based on transactions, but Otel does sampling on a span basis.
@sl0thentr0py sl0thentr0py self-assigned this Jul 22, 2024
@antonpirker antonpirker mentioned this issue Aug 24, 2024
Closed
@antonpirker antonpirker mentioned this issue Sep 5, 2024
Merged
@antonpirker antonpirker changed the title Figure out sampling story in POTel Sampling in POtel Sep 5, 2024
antonpirker added a commit that referenced this issue Sep 10, 2024
@antonpirker
Potel Sampling (#3501)
3b54bbf 
Add a new SentrySampler that is used for sampling OpenTelemetry spans the Sentry way (using Sentrys traces_sample_rate and traces_sampler config options)

Fixes #3318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonpirker antonpirker

Labels
Integration: OpenTelementry (OTel) Project: POTel (Phase 1)
Projects
None yet
Milestone
Performance powered by OTel (POTel)
Development

Successfully merging a pull request may close this issue.

Potel Sampling getsentry/sentry-python
WIP: Potel sampling getsentry/sentry-python
3 participants
@antonpirker @sl0thentr0py @sentrivana