Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potel Sampling #3501

Merged
merged 21 commits into from
Sep 10, 2024
Merged

Potel Sampling #3501

merged 21 commits into from
Sep 10, 2024

Conversation

antonpirker
Copy link
Member

Add a new SentrySampler that is used for sampling OpenTelemetry spans the Sentry way (using Sentrys traces_sample_rate and traces_sampler config options)

Fixes #3318

@antonpirker antonpirker changed the base branch from master to potel-base September 5, 2024 12:03
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

❌ 3444 Tests Failed:

Tests completed Failed Passed Skipped
17047 3444 13603 1917
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_transaction_events[<lambda>1-error]
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_client_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.httpx.test_httpx test_option_trace_propagation_targets[httpx_client14-trace_propagation_targets14-https://example.com-True]
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker antonpirker mentioned this pull request Sep 5, 2024
Closed
sl0thentr0py
sl0thentr0py requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for taking care of this! left a few comments first

sentry_sdk/integrations/opentelemetry/sampler.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/sampler.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/sampler.py Outdated Show resolved Hide resolved
sl0thentr0py
sl0thentr0py approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, ty!

@antonpirker antonpirker marked this pull request as ready for review September 10, 2024 12:09
@antonpirker antonpirker merged commit 3b54bbf into potel-base Sep 10, 2024
9 of 106 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/sampling branch September 10, 2024 12:10
@antonpirker antonpirker mentioned this pull request Sep 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
Project: POTel (Phase 1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sampling in POtel
2 participants
@antonpirker @sl0thentr0py