Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): Add getDefaultConfig option to getSentryExpoConfig #3690

Conversation

krystofwoldrich
Copy link
Member

For special setups like our own repository, where the Sentry Metro Plugin is outside of the project structure it's needed to supply the correct (from the project node modules) default config.

Otherwise, some features might not work, for example, hbc bundles are not emitted.

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8e725f9

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.13 ms 430.96 ms 22.83 ms
Size 17.73 MiB 19.93 MiB 2.19 MiB

* misc(sample): Disable Expo Web static routes, export command hangs

* misc(sample): Enable expo-router auto instrumentation

* Revert "misc(sample): Disable Expo Web static routes, export command hangs"

This reverts commit 4a4c27d.
Base automatically changed from kw-avoid-executing-sentry-during-export to kw-add-expo-router-instrumentation-to-sample-app March 20, 2024 14:26
@lucas-zimerman lucas-zimerman merged commit e71244d into kw-add-expo-router-instrumentation-to-sample-app Mar 20, 2024
49 of 53 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-allow-default-config-overwrite branch March 20, 2024 18:59
krystofwoldrich added a commit that referenced this pull request Mar 21, 2024
* misc(sample): Move `Sentry.init` to the root `_layout`

* misc(sample): Do not execute Sentry in NodeJS during npx expo export command (#3689)

* feat(expo): Add getDefaultConfig option to getSentryExpoConfig (#3690)

* misc(sample): Do not execute Sentry in NodeJS during npx expo export command

* feat(expo): Add `getDefaultConfig` option to `getSentryExpoConfig`

* misc(sample): Enable expo-router auto instrumentation (#3692)

* misc(sample): Disable Expo Web static routes, export command hangs

* misc(sample): Enable expo-router auto instrumentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants