-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(sample): Enable expo-router auto instrumentation #3692
Merged
lucas-zimerman
merged 4 commits into
kw-allow-default-config-overwrite
from
kw-add-expo-router-sentry-auto-instrumentation
Mar 20, 2024
Merged
misc(sample): Enable expo-router auto instrumentation #3692
lucas-zimerman
merged 4 commits into
kw-allow-default-config-overwrite
from
kw-add-expo-router-sentry-auto-instrumentation
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
krystofwoldrich
changed the base branch from
kw-disable-static-web-routes
to
kw-allow-default-config-overwrite
March 19, 2024 17:46
…hangs" This reverts commit 4a4c27d.
lucas-zimerman
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lucas-zimerman
merged commit Mar 20, 2024
92091ea
into
kw-allow-default-config-overwrite
49 of 53 checks passed
lucas-zimerman
deleted the
kw-add-expo-router-sentry-auto-instrumentation
branch
March 20, 2024 14:26
lucas-zimerman
added a commit
that referenced
this pull request
Mar 20, 2024
* misc(sample): Do not execute Sentry in NodeJS during npx expo export command * feat(expo): Add `getDefaultConfig` option to `getSentryExpoConfig` * Update CHANGELOG.md * misc(sample): Enable expo-router auto instrumentation (#3692) * misc(sample): Disable Expo Web static routes, export command hangs * misc(sample): Enable expo-router auto instrumentation * Revert "misc(sample): Disable Expo Web static routes, export command hangs" This reverts commit 4a4c27d. --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
krystofwoldrich
added a commit
that referenced
this pull request
Mar 21, 2024
* misc(sample): Move `Sentry.init` to the root `_layout` * misc(sample): Do not execute Sentry in NodeJS during npx expo export command (#3689) * feat(expo): Add getDefaultConfig option to getSentryExpoConfig (#3690) * misc(sample): Do not execute Sentry in NodeJS during npx expo export command * feat(expo): Add `getDefaultConfig` option to `getSentryExpoConfig` * misc(sample): Enable expo-router auto instrumentation (#3692) * misc(sample): Disable Expo Web static routes, export command hangs * misc(sample): Enable expo-router auto instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Expo Router auto instrumentation to the Expo sample app.
#skip-changelog