Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(sample): Enable expo-router auto instrumentation #3692

Conversation

krystofwoldrich
Copy link
Member

This PR adds Expo Router auto instrumentation to the Expo sample app.

#skip-changelog

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 399.18 ms 431.19 ms 32.00 ms
Size 17.73 MiB 19.93 MiB 2.19 MiB

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 387.55 ms 419.79 ms 32.24 ms
Size 7.15 MiB 8.20 MiB 1.05 MiB

@krystofwoldrich krystofwoldrich changed the base branch from kw-disable-static-web-routes to kw-allow-default-config-overwrite March 19, 2024 17:46
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit 92091ea into kw-allow-default-config-overwrite Mar 20, 2024
49 of 53 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-add-expo-router-sentry-auto-instrumentation branch March 20, 2024 14:26
lucas-zimerman added a commit that referenced this pull request Mar 20, 2024
* misc(sample): Do not execute Sentry in NodeJS during npx expo export command

* feat(expo): Add `getDefaultConfig` option to `getSentryExpoConfig`

* Update CHANGELOG.md

* misc(sample): Enable expo-router auto instrumentation (#3692)

* misc(sample): Disable Expo Web static routes, export command hangs

* misc(sample): Enable expo-router auto instrumentation

* Revert "misc(sample): Disable Expo Web static routes, export command hangs"

This reverts commit 4a4c27d.

---------

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
krystofwoldrich added a commit that referenced this pull request Mar 21, 2024
* misc(sample): Move `Sentry.init` to the root `_layout`

* misc(sample): Do not execute Sentry in NodeJS during npx expo export command (#3689)

* feat(expo): Add getDefaultConfig option to getSentryExpoConfig (#3690)

* misc(sample): Do not execute Sentry in NodeJS during npx expo export command

* feat(expo): Add `getDefaultConfig` option to `getSentryExpoConfig`

* misc(sample): Enable expo-router auto instrumentation (#3692)

* misc(sample): Disable Expo Web static routes, export command hangs

* misc(sample): Enable expo-router auto instrumentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants