Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(escalating-issues): Use ui flag escalating-issues-ui #47408

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

scttcper
Copy link
Member

Allows for us to play with the ui via flagr

Allows for us to play with the ui via flagr
@scttcper scttcper requested a review from a team April 14, 2023 18:44
@scttcper scttcper requested a review from a team as a code owner April 14, 2023 18:44
@scttcper scttcper changed the title feat(escalating-issues): Switch ui to escalating-issues-ui feat(escalating-issues): Switch ui flag to escalating-issues-ui Apr 14, 2023
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 14, 2023
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@scttcper scttcper changed the title feat(escalating-issues): Switch ui flag to escalating-issues-ui feat(escalating-issues): Switch ui flag to escalating-issues-ui Apr 14, 2023
@@ -212,6 +212,7 @@
default_manager.add("organizations:dynamic-sampling", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
default_manager.add("organizations:dynamic-sampling-transaction-name-priority", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
default_manager.add("organizations:escalating-issues", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
default_manager.add("organizations:escalating-issues-ui", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, FeatureHandlerStrategy.REMOTE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the one just above and this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ui and its flagr enabled. i can put a better comment

@armenzg armenzg added this to the Escalating Issues V1 milestone Apr 14, 2023
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That helps 😄

@scttcper scttcper changed the title feat(escalating-issues): Switch ui flag to escalating-issues-ui feat(escalating-issues): Use ui flag escalating-issues-ui Apr 17, 2023
@scttcper scttcper merged commit 5636340 into master Apr 17, 2023
@scttcper scttcper deleted the scttcper/escalating-issues-ui branch April 17, 2023 16:36
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants