Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(escalating-issues): Use ui flag escalating-issues-ui #47408

Merged
merged 2 commits into from
Apr 17, 2023
Merged

feat(escalating-issues): Use ui flag escalating-issues-ui #47408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fcbc8e
feat(escalating-issues): Switch ui to escalating-issues-ui
scttcper Apr 14, 2023
7f70aba
add comment about post processing
scttcper Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/conf/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,8 @@ def SOCIAL_AUTH_DEFAULT_USERNAME():
"organizations:discover-query": True,
# Enable archive/escalating issue workflow
"organizations:escalating-issues": False,
# Enable archive/escalating issue workflow UI, enable everything except post processing
"organizations:escalating-issues-ui": False,
# Allows an org to have a larger set of project ownership rules per project
"organizations:higher-ownership-limit": False,
# Enable Performance view
Expand Down
1 change: 1 addition & 0 deletions src/sentry/features/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@
default_manager.add("organizations:dynamic-sampling", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
default_manager.add("organizations:dynamic-sampling-transaction-name-priority", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
default_manager.add("organizations:escalating-issues", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
default_manager.add("organizations:escalating-issues-ui", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
default_manager.add("organizations:event-attachments", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
default_manager.add("organizations:global-views", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
default_manager.add("organizations:incidents", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/group/inboxBadges/inboxReason.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function InboxReason({inbox, fontSize = 'sm', showDateAdded}: Props) {
tooltipDescription?: string | React.ReactNode;
tooltipText?: string;
} {
const hasEscalatingIssues = organization.features.includes('escalating-issues');
const hasEscalatingIssues = organization.features.includes('escalating-issues-ui');
switch (reason) {
case GroupInboxReason.UNIGNORED:
return {
Expand Down
2 changes: 1 addition & 1 deletion static/app/stores/tagStore.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('TagStore', function () {
]);

const tags = TagStore.getIssueAttributes(
TestStubs.Organization({features: ['escalating-issues']})
TestStubs.Organization({features: ['escalating-issues-ui']})
);
expect(tags.is.values).toContain('archived');
expect(tags.is.values).not.toContain('ignored');
Expand Down
2 changes: 1 addition & 1 deletion static/app/stores/tagStore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const storeConfig: TagStoreDefinition = {
const isSuggestions = [
'resolved',
'unresolved',
org.features.includes('escalating-issues') ? 'archived' : 'ignored',
org.features.includes('escalating-issues-ui') ? 'archived' : 'ignored',
'assigned',
'for_review',
'unassigned',
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueDetails/actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ class Actions extends Component<Props> {
share: shareCap,
} = getConfigForIssueType(group).actions;

const hasEscalatingIssues = organization.features.includes('escalating-issues');
const hasEscalatingIssues = organization.features.includes('escalating-issues-ui');
const hasDeleteAccess = organization.access.includes('event:admin');
const activeSuperUser = isActiveSuperuser();

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/actions/actionSet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ function ActionSet({
/>
)}

{organization.features.includes('escalating-issues') ? (
{organization.features.includes('escalating-issues-ui') ? (
<ArchiveActions
onUpdate={onUpdate}
shouldConfirm={onShouldConfirm(ConfirmAction.IGNORE)}
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/overview.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ describe('IssueList', function () {
<IssueListWithStores
{...routerProps}
{...defaultProps}
organization={{...organization, features: ['escalating-issues']}}
organization={{...organization, features: ['escalating-issues-ui']}}
/>,
{
context: routerContext,
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function getTabs(organization: Organization) {
Issues are automatically marked reviewed in 7 days.`),
},
],
organization.features.includes('escalating-issues')
organization.features.includes('escalating-issues-ui')
? [
Query.ARCHIVED,
{
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/organizationDeveloperSettings/subscriptionBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function SubscriptionBox({
const DESCRIPTIONS: Record<(typeof EVENT_CHOICES)[number], string> = {
// Swap ignored for archived if the feature is enabled
issue: `created, resolved, assigned, ${
features.includes('escalating-issues') ? 'archived' : 'ignored'
features.includes('escalating-issues-ui') ? 'archived' : 'ignored'
}`,
error: 'created',
comment: 'created, edited, deleted',
Expand Down