Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replays): Log to stdout when a slow click event is detected #48775

Merged
merged 4 commits into from
May 15, 2023
Merged

feat(replays): Log to stdout when a slow click event is detected #48775

merged 4 commits into from
May 15, 2023

Conversation

cmanallen
Copy link
Member

Temporary measure to evaluate how common slow click events are.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #48775 (e7ef27d) into master (b24987f) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

❗ Current head e7ef27d differs from pull request most recent head 6038095. Consider uploading reports for the commit 6038095 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #48775      +/-   ##
==========================================
- Coverage   80.92%   80.87%   -0.05%     
==========================================
  Files        4819     4819              
  Lines      202008   202623     +615     
  Branches    11412    11513     +101     
==========================================
+ Hits       163469   163870     +401     
- Misses      38285    38498     +213     
- Partials      254      255       +1
Impacted Files Coverage Δ
src/sentry/replays/usecases/ingest/dom_index.py 83.33% <66.66%> (-2.59%) ⬇️

... and 224 files with indirect coverage changes

@cmanallen
Copy link
Member Author

Related: #48259

@cmanallen cmanallen marked this pull request as ready for review May 12, 2023 19:51
@cmanallen cmanallen requested a review from a team as a code owner May 12, 2023 19:51
@cmanallen cmanallen merged commit 0c9ab30 into master May 15, 2023
@cmanallen cmanallen deleted the cmanallen/replays-log-slow-clicks branch May 15, 2023 14:53
volokluev pushed a commit that referenced this pull request May 30, 2023
@cmanallen @volokluev
feat(replays): Log to stdout when a slow click event is detected (#48775
aaf2668 
)

Temporary measure to evaluate how common slow click events are.
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmanallen @JoshFerge