Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replays): Log to stdout when a slow click event is detected #48775

Merged
merged 4 commits into from
May 15, 2023
Merged

feat(replays): Log to stdout when a slow click event is detected #48775

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d6b35f
Log slow clicks
cmanallen May 9, 2023
a765e42
Use sentry.replays logger and log payload as structured output
cmanallen May 12, 2023
e7ef27d
Specify project_id in test coverage
cmanallen May 12, 2023
6038095
Merge branch 'master' into cmanallen/replays-log-slow-clicks
cmanallen May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/sentry/replays/usecases/ingest/dom_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
import time
import uuid
from hashlib import md5
Expand All @@ -8,6 +9,8 @@
from sentry.utils import json, kafka_config, metrics
from sentry.utils.pubsub import KafkaPublisher

logger = logging.getLogger()
cmanallen marked this conversation as resolved.
Show resolved Hide resolved

EVENT_LIMIT = 20

replay_publisher: Optional[KafkaPublisher] = None
Expand Down Expand Up @@ -131,7 +134,10 @@ def get_user_actions(

if event.get("type") == 5 and event.get("data", {}).get("tag") == "breadcrumb":
payload = event["data"].get("payload", {})
if payload.get("category") == "ui.click":
category = payload.get("category")
if category == "ui.slowClickDetected":
logger.info(f"Slow click detected: {json.dumps(payload)}")
cmanallen marked this conversation as resolved.
Show resolved Hide resolved
elif category == "ui.click":
node = payload.get("data", {}).get("node")
if node is None:
continue
Expand Down