Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable queries using project slug as filter and groupby in Metrics API #69111

Merged
merged 24 commits into from
Apr 18, 2024
Merged

Enable queries using project slug as filter and groupby in Metrics API #69111

merged 24 commits into from
Apr 18, 2024

Commits on Apr 17, 2024

  1. Add visitor to replace project-filter by project-id-filter in query

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    956b9b3 View commit details
    Browse the repository at this point in the history

  2. Add visitor to replace groupby:project by groupby:project_id

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2fbf999 View commit details
    Browse the repository at this point in the history

  3. wip: generalize

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ab65551 View commit details
    Browse the repository at this point in the history

  4. wip: implement first running version of modulator-visitor based on fl… 

    …exibly defined modulators
    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d53d659 View commit details
    Browse the repository at this point in the history

  5. add query post-processing steps

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0518514 View commit details
    Browse the repository at this point in the history

  6. wip: fix bugs & restructure

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    08caa89 View commit details
    Browse the repository at this point in the history

  7. wip: everything works before cleanup

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5034dbb View commit details
    Browse the repository at this point in the history

  8. wip: cleanup

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    164836f View commit details
    Browse the repository at this point in the history

  9. wip: remove ModulationMetadata - not needed

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a8e14a1 View commit details
    Browse the repository at this point in the history

  10. wip: move things around

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7b830af View commit details
    Browse the repository at this point in the history

  11. wip: inject projects directly into the visitor that needs it instead … 

    …of passing it around
    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    bc5a402 View commit details
    Browse the repository at this point in the history

  12. wip: move groupby modulation into function for ModulatorVisitor

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2f9f9c8 View commit details
    Browse the repository at this point in the history

  13. add tests & refactor

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a8d757f View commit details
    Browse the repository at this point in the history

  14. wip: fix mypy errors

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6a1e9e1 View commit details
    Browse the repository at this point in the history

  15. add more tests & refactor

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0a8142d View commit details
    Browse the repository at this point in the history

  16. remove comment

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a414b9a View commit details
    Browse the repository at this point in the history

  17. refactor into optimized object structure to reduce shared state

    @shellmayr
    shellmayr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    008d7c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. refactor naming

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    13e6e5c View commit details
    Browse the repository at this point in the history

  2. remove find_modulator

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    941dafd View commit details
    Browse the repository at this point in the history

  3. rename QueryDemodulationStep

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2a20d60 View commit details
    Browse the repository at this point in the history

  4. wip: work review comments into PR

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c70c225 View commit details
    Browse the repository at this point in the history

  5. wip: add test for groupby:project and filter:project_id

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4bf4cc7 View commit details
    Browse the repository at this point in the history

  6. last adaptations to pacify mypy

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7f3e47f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into shellmayr/feat/project-to-project-id-draft-2

    @shellmayr
    shellmayr committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0146d86 View commit details
    Browse the repository at this point in the history