-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable queries using project slug as filter and groupby in Metrics API #69111
Enable queries using project slug as filter and groupby in Metrics API #69111
Conversation
…exibly defined modulators
…of passing it around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, this paves the way for a great extensible foundation for aliasing in the API.
Left some comments and some nits, after some of those are resolved, we are good to go.
src/sentry/sentry_metrics/querying/data/postprocessing/remapping.py
Outdated
Show resolved
Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py
Outdated
Show resolved
Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py
Outdated
Show resolved
Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Closes #68416