ref(am1): Collect span counts for orgs prior to migrating #75485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some organizations are not yet on AM2, and are unsampled without span extraction running, which makes it hard to estimate usage for future plan changes to AM3. This allows us to collect metrics for only those specific customers who we can't estimate through outcomes.
github-actions
bot
added
the
Scope: Backend
phacops
approved these changes
Aug 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75485 +/- ##
========================================
Coverage 78.18% 78.19%
========================================
Files 6809 6816 +7
Lines 302915 303037 +122
Branches 52132 52149 +17
========================================
+ Hits 236844 236954 +110
- Misses 59686 59690 +4
- Partials 6385 6393 +8
|
jjbayer
reviewed
Aug 2, 2024
| @@ -187,6 +187,8 @@ def process_event( | |||
| event_id=event_id, | |||
| project_id=project_id, | |||
| ) | |||
| collect_span_metrics(project, data) | |||
There was a problem hiding this comment.
Can we move this into save_event_transaction, and / or wrap it in a try / catch?
This line is part of a try block, but it only DLQs KeyErrors. Any other failure might block the consumer and cause a P0 incident.
sentry/src/sentry/ingest/consumer/processors.py
Lines 141 to 142 in 503314b
There was a problem hiding this comment.
Wrap in a try/catch is a good idea, sure 👍
|
PR reverted: 2680cfa |
|
@k-fish this was reverted for INC-842, please review when you're back. |
k-fish
added a commit
that referenced
this pull request
Aug 8, 2024
We ran into trouble with the previous PR due to a few issues; a typo in the name, exception logging in the 'has' causing a thundering herd of exceptions, and the condition order causing the problem to not trip tests / soak time. original PR for context: #75485 Notes: - `am3_tier` vs `am3-tier` as a result of a bad copy paste (out of a thread instead of the file it's registered) - `logger.exception` circumventing the `try / except`, already fixed [here](687086f#diff-9cd8ed7a349a276392e908cabcd613d3647a94eaa5956ae79e4efb604e2c9232L309) - Conditional order has `organizations:dynamic-sampling` first, which causes an early shortcut of the `and`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some organizations are not yet on AM2, without span extraction running, which makes it hard to estimate usage for future plan changes to AM3. This allows us to collect metrics for only those specific customers who we can't estimate through outcomes.
Flag I'm using in lieu of a new option is from the subscription plan handler, should be similarly fast to an option in region mode.