fix(am1): Add span count metric (unrevert) #75827
Merged
+42
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into trouble with the previous PR due to a few issues; a typo in the name, exception logging in the 'has' causing a thundering herd of exceptions, and the condition order causing the problem to not trip tests / soak time.
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into trouble with the previous PR due to a few issues; a typo in the name, exception logging in the 'has' causing a thundering herd of exceptions, and the condition order causing the problem to not trip tests / soak time.
original PR for context: #75485
Notes:
am3_tiervsam3-tieras a result of a bad copy paste (out of a thread instead of the file it's registered)logger.exceptioncircumventing thetry / except, already fixed hereorganizations:dynamic-samplingfirst, which causes an early shortcut of theand