chore(replay): ff to test reduced timeout for rage/dead clicks #77284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
michellewzhang
approved these changes
Sep 10, 2024
| @@ -399,6 +399,8 @@ def register_temporary_features(manager: FeatureManager): | |||
| manager.add("organizations:session-replay-new-event-counts", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False) | |||
| # Enable Rage Click Issue Creation In Recording Consumer | |||
| manager.add("organizations:session-replay-rage-click-issue-creation", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False) | |||
| # Enable a reduced timeout when waiting for the DOM, before reporting Rage and Dead clicks | |||
| manager.add("organizations:session-replay-dead-click-reduced-timeout", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, default=False, api_expose=False) | |||
There was a problem hiding this comment.
I realize I'm too late, but could the timeout be set in the option itself? instead of a bool value?
The key then could be rage-click-timeout (are we also changing the definition for Dead? if so then dead-click-timeout).
There was a problem hiding this comment.
The timeout applies to both rage and dead clicks. Yeah we can make an option, since the other PRs haven't merged yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This timeout is in dom_index.py (7000ms) and is the time we wait for dom changes before reporting a rage or dead click.
Trying out 5s instead of 7 for sentry orgs. Slack thread: https://sentry.slack.com/archives/C03USURCFBJ/p1725645076151569