Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): try 5s rage/dead click timeout for select orgs, using options #77325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Sep 11, 2024

Replaces #77286 and #77284

Depends on #77365

@aliu39 aliu39 requested a review from a team as a code owner September 11, 2024 17:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 11, 2024
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't mean to say that you should have replaced the feature flag -- that part was totally fine. just meant to say you could use an option to control the rage/deadclick timeout

@aliu39
Copy link
Member Author

aliu39 commented Sep 11, 2024

didn't mean to say that you should have replaced the feature flag -- that part was totally fine. just meant to say you could use an option to control the rage/deadclick timeout

True! This is all backend tho so we can just do 1 PR w/2 options

Copy link

codecov bot commented Sep 11, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
21542 1 21541 205
View the top 1 failed tests by shortest run time
tests.snuba.api.endpoints.test_organization_events_span_indexed.OrganizationEventsEAPSpanEndpointTest test_extrapolation_smoke
Stack Traces | 24.1s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_events_span_indexed.py#x1B[0m:587: in test_extrapolation_smoke
    assert response.status_code == 200, f"error: {response.content}\naggregate: {function}"
#x1B[1m#x1B[31mE   BytesWarning: str() on a bytes instance#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

organization = Project.objects.get(id=project_id).organization
dead_click_timeout = (
reduced_dead_click_timeout
if organization.slug in options.get("feedback.dead-click.reduced-timeout-org-list")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use the org slug because we need to query for it. We have the org_id and the project_id. We could use those with the option directly so you don't need to query anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants