Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No work has been submitted for this frame" timeout #3189

Closed
Beyley opened this issue Nov 8, 2022 · 1 comment · Fixed by #5200
Closed

"No work has been submitted for this frame" timeout #3189

Beyley opened this issue Nov 8, 2022 · 1 comment · Fixed by #5200
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working

Comments

@Beyley
Copy link

Beyley commented Nov 8, 2022

Description
If you do not submit any work for a surface, and present it, problems occur running wgpuSwapChainGetCurrentTextureView (wgpu-native), it seems to be hitting this line specifically

Repro steps
You can just strip out all code that submits work from any rendering example

Expected vs observed behavior
Nothing should happen, and wgpuSwapChainGetCurrentTextureView should run just fine, but it does not, sometimes failing with a timeout, sometimes working

Extra materials
the 'beginning scene' is where i get the swap chain's current texture view, things marked with 'CallbackError' are errors from wgpuDeviceSetUncapturedErrorCallback
image

Platform
Arch Linux, AMD GPU, latest master of wgpu-native
@Beyley Beyley changed the title No work has been submitted for this frame "No work has been submitted for this frame" timeout Nov 8, 2022
@teoxoy
Copy link
Member

teoxoy commented Feb 24, 2023

I don't really understand why we need the has_work flag. Mapping !has_work to SurfaceError::Outdated doesn't seem ideal. Does presenting a surface that hasn't changed cause any issues?

#1892 (PR that introduced the flag) mentiones:

Adds has_work flag to surface textures. This is temporary, until #1688 takes a better care of it.

Considering #1688 has been merged, can we get rid of has_work and just present the surface?

@cwfitzgerald do you have more context for this (since you reviewed #1892)?

@teoxoy teoxoy added type: bug Something isn't working api: vulkan Issues with Vulkan labels Feb 24, 2023
@B-head B-head mentioned this issue Jul 10, 2023
Draft
8 tasks
waywardmonkeys added a commit to waywardmonkeys/wgpu that referenced this issue Feb 5, 2024
@waywardmonkeys
Remove TextureInner::Surface::has_work.
bac8999 
When no work is submitted for a frame, presenting the surface results
in a timeout due to no work having been submitted.

Fixes gfx-rs#3189.

This flag was added in gfx-rs#1892 with a note that it was going to be
temporary until gfx-rs#1688 landed.
@waywardmonkeys waywardmonkeys mentioned this issue Feb 5, 2024
Merged
6 tasks
waywardmonkeys added a commit to waywardmonkeys/wgpu that referenced this issue Feb 5, 2024
@waywardmonkeys
Remove TextureInner::Surface::has_work.
9bd29f7 
When no work is submitted for a frame, presenting the surface results
in a timeout due to no work having been submitted.

Fixes gfx-rs#3189.

This flag was added in gfx-rs#1892 with a note that it was going to be
temporary until gfx-rs#1688 landed.
waywardmonkeys added a commit to waywardmonkeys/wgpu that referenced this issue Feb 5, 2024
@waywardmonkeys
Remove TextureInner::Surface::has_work.
d348866 
When no work is submitted for a frame, presenting the surface results
in a timeout due to no work having been submitted.

Fixes gfx-rs#3189.

This flag was added in gfx-rs#1892 with a note that it was going to be
temporary until gfx-rs#1688 landed.
nical pushed a commit that referenced this issue Feb 9, 2024
@waywardmonkeys
Remove TextureInner::Surface::has_work. (#5200)
665c075 
When no work is submitted for a frame, presenting the surface results
in a timeout due to no work having been submitted.

Fixes #3189.

This flag was added in #1892 with a note that it was going to be
temporary until #1688 landed.
@jimblandy jimblandy mentioned this issue Feb 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove TextureInner::Surface::has_work. waywardmonkeys/wgpu
2 participants
@teoxoy @Beyley