Zero init textures #1688
Merged
Zero init textures #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jul 22, 2021
Wumpf
force-pushed
the
zero-init-textures
branch
2 times, most recently
from
e4cd399
to
dfaffa6
Compare
This was referenced Aug 21, 2021
Wumpf
force-pushed
the
zero-init-textures
branch
from
dfaffa6
to
bbb9202
Compare
Wumpf
force-pushed
the
zero-init-textures
branch
2 times, most recently
from
533a2f8
to
ae11fe2
Compare
sadly, they are typically passing even if texture zero init isn't doing its job However, they form nice isolated examples for testing out texture initialization It could be possible to dirty texture memory prior to ensure zero init did the job
* queue submit * write_texture
enforce COPY_DST usage now on all textures
init_tracker has now a `discard` function to get single data points back to uninitialized use new standardized partition_point function
missing: * init on the fly if discarded is found within command buffer * handle discarding only stencil or only depth
…through utility function allows to resolve discard/init_action interactions
CommandBufferTextureMemoryActions is now fully encapsulated
Wumpf
force-pushed
the
zero-init-textures
branch
from
ae11fe2
to
bb0aaab
Compare
kvark
reviewed
Oct 25, 2021
There was a problem hiding this comment.
I've done the first review pass. This is grand piece of work!
When the group was deciding to zero-init resources, I didn't expect this to be associated with so much complexity. And I hoped this would work together with the state tracker, while you've shown that it's better off to be a completely independent system.
neither did I. Very unlikely I would have promised to look after this thing if I knew 😄 |
Wumpf
force-pushed
the
zero-init-textures
branch
from
3047510
to
b48d444
Compare
kvark
approved these changes
Oct 28, 2021
|
We have a bit of clippy complains, otherwise let's ship it! |
kvark
approved these changes
Oct 28, 2021
|
🥳 finally, what a relief! |
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
6 tasks
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
nical
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #1102
Some preparatory work happened in: #2081, #2046, #1905, #1839
Description
Implements zero texture init using some of the same building blocks & patterns already used for buffer zero init.
Moved "inter-submit" init code to a new mod which also has utlitities to tackle the rare texure inits ("fixups") that may happen due to a discarded texture being used within an encoder/cmd-buf. The machinery for this is a bit clunky right now and may be improved down the line.
Special-special handling is given for depth/stencil discards, there are comment blocks that should explain the situation and approach (if those aren't clear enough this needs fixing as well).
Testing
Started out with new / rearranged player tests. For testing the more complicated sideffects of render target discards, a new regular unit test is added.
Overall, I believe testing is about the bare minimum that we can run with for now, but devising good ones is challenging on its own as so often.