Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Error: Not able to parse artifact type: undefined #199

Closed
einanli opened this issue Dec 1, 2020 · 3 comments · Fixed by #264
Closed

Error: Not able to parse artifact type: undefined #199

einanli opened this issue Dec 1, 2020 · 3 comments · Fixed by #264
Assignees
Labels
bug Something isn't working O: stale 🤖

Comments

@einanli
Copy link

einanli commented Dec 1, 2020

Describe the bug
Using a lowercase Rally Story Id in the pull request body is resulting in an exception.
"Error occurred while validating Rally Artifacts: Error: Not able to parse artifact type: undefined"

To Reproduce
Steps to reproduce the behavior:

  1. Create a new PR
  2. in the body of the PR add a Rally story usxxxx (lower case us)
  3. check the Rally integration details
  4. see the error "Error occurred while validating Rally Artifacts: Error: Not able to parse artifact type: undefined"

Expected behavior
If this is considered an invalid Rally Story id, we should get a validation failed result rather than an exception.
The other option is making the check case insensitive.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
If you edit the PR body, and change the story id to upper case, this fixes the issue.

Here's my test config file:

---
# Name of the GitHub Check
checksName: integrations/rally

# Check PR Body for Rally story/defect (true | false)
checkPRBody: true

# Check PR Title for Rally story/defect (true | false)
checkPRTitle: false

# Check all commit messages for a Rally story/defect (true | false)
checkCommitMessages: false

# Set Rally Flow State to Complete on merge if the PR Body contains "/completes <DEFECT/STORY ID>"
mergeOnPRBody: true

# Comment on the PR in addition to the check message? (true | false)
commentOnPull: false

rally:
  server: https://rally1.rallydev.com
  workspace: xxxxxxxxxxx

  # Which projects this repo will link to.
  projects:
    - TEST Squad 1
    - TEST Squad 2

  # List of valid Rally objects to check
  objects:
    - defect
    - task
    - userstory
    - story

  # List of Rally states that an issue must be in in order to pass
  states:
    - Ready
    - Defined
    - In-Progress

@einanli einanli added the bug Something isn't working label Dec 1, 2020
@primetheus primetheus self-assigned this Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Jan 1, 2021

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@ineffyble
Copy link
Contributor

This should stay open.

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

vorobievalex added a commit to vorobievalex/rally that referenced this issue May 6, 2021
since Rally API returns 'undefined' errors for lowercase artifacts.
primetheus pushed a commit that referenced this issue May 7, 2021
fix: #199 transform found Rally artifacts to upper case
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.