Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform found Rally artifacts to upper case #2

Closed
wants to merge 8 commits into from

Conversation

vorobievalex
Copy link
Owner

since Rally API returns 'unefined' errors for lowercase artifacts.
"Error occurred while validating Rally Artifacts: Error: Not able to parse artifact type: undefined"

Fixes github#199

Proposed Changes

  • allow lowercase artifacts like us12345 in text, but transform it to uppercase for the Rally API

Readiness Checklist

  • If this change requires documentation, it has been included in this pull request

Reviewer Checklist

  • If a functional change has occurred, testing the integration has been performed
  • This PR has been categorized with a label (1 of automation, bug, documentation, enhancement, infrastructure, or performance) for the changelog

dependabot bot and others added 8 commits May 5, 2021 12:49
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.0.0...4.1.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Bumps [github/super-linter](https://github.com/github/super-linter) from v3.15.5 to v3.16.1.
- [Release notes](https://github.com/github/super-linter/releases)
- [Commits](github/super-linter@v3.15.5...e1d24f2)

Signed-off-by: dependabot[bot] <support@github.com>
- test 'check_run rerequested' added to test it
- test methods that should be async made async
- commentOnPull made true to also test the appropriate code path
- handlePullRequest in tests replaced with handlePullRequestWithRally to escape creating real rally instance, that runs its own asyncs, that are left after the tesrts are over
- setup.js with fail on unhandledRejection added to catch async warnings like the one appeared with the absent Connections._ref in rallyClient
since Rally API returns 'unefined' errors for lowercase artifacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Not able to parse artifact type: undefined
2 participants