Properly log out on Account Deletion #2692
Conversation
|
/werft run 👍 started the job as gitpod-build-at-logout-on-delete.1 |
|
/werft run 👍 started the job as gitpod-build-at-logout-on-delete.2 |
| <DialogContent> | ||
| <Typography variant="body1"> | ||
| <div>Your account has been deleted and your browser will be redirected to the logout.</div> | ||
| <div>Feel free to try out Gitpod again. No hard feelings 🙂</div> |
There was a problem hiding this comment.
@gtsiolis @svenefftinge Is the messaging ok here?
There was a problem hiding this comment.
BTW, 'reworded, because "to logout using the finish button below" is part of the problem solve in this PR.
There was a problem hiding this comment.
question: Do we need this extra (second) dialog for technical reasons?
- If not, I'd suggest removing it and redirecting to
www.gitpod.ioafter confirming deletion in the first dialog. In the future we could redirect to a dedicated the sign up page. Feel free to open a follow up issue for this. - If yes, here are some potential improvements that could go into this PR:
- ..will be redirected to the logout does not sound accurate, right? We could skip mentioning the redirection.
- We could rename the second sentence to something like Thanks for trying out Gitpod.
issue: This is out of the scope of this PR, but visible page contents during page reload are also an issue for anonymous users, see #2509.
Thanks for the ping @csweichel! 🏓
There was a problem hiding this comment.
@gtsiolis, thanks!
great hint, and there isn't a technical reason anymore (as of this PR.)
follow up on this suggestion: would you expect to see any confirmation of the successful deletion at all, or is a plain redirection to www.gitpod.io just right?
There was a problem hiding this comment.
@gtsiolis, please give it a try 🙏🏻
There was a problem hiding this comment.
@AlexTugarev looks good! I don't think we will need the second dialog in the long run but a loading indicator makes sense. Long term we could either use a loading button state (see screenshot below) or a page-wide progress bar like the one we use for environment (workspace) loading.
Once we have a dedicated the sign up page we can consider redirecting users there so that both gitpod.io and self hosted users have a similar overall UX.
There was a problem hiding this comment.
I don't think we will need the second dialog
which one?
maybe it's the structure of the React component which is a bit confusing? there are three ways to render a We are sorry to see you go dialog. I mean that's all the same dialog, but the content is changing to indicate progress and resolution.
There was a problem hiding this comment.
@AlexTugarev I'm referring to the second dialog shown after confirming deletion that contains the title We are sorry to see you go and the body message Redirecting....
What I meant earlier is that we do not need the second dialog at all. But leaving this as is for now is fine.
but the content is changing to indicate progress and resolution.
For this, see #2692 (comment). ❤️
There was a problem hiding this comment.
I see. I didn't even notice the last rendering of Redirecting..., maybe because the redirect happens to be fast enough. All three dialog states were a single dialog for me. The idea was to fill in the gap between dismissing the progress indicator and a potentially slow redirect of the browser.
But leaving this as is for now is fine.
Can you then give a thumb up on merging?
Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev
force-pushed
the
at/logout-on-delete
branch
from
e5e97ff
to
d86aa57
Compare
Resolves #2645
This also includes a fix for deleting GCS buckets which aren't empty.
how to test