Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin panel] Add delete user button #2860

Merged
merged 1 commit into from
Jan 13, 2021
Merged

[admin panel] Add delete user button #2860

merged 1 commit into from
Jan 13, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Jan 12, 2021 •
edited
Loading

How to test:

$ licensor sign --key ./components/licensor/private_demo_key.pem --domain corneliusludmann-admin-panel-delete-2849.staging.gitpod-dev.com --seats 10000 --valid-for 17520h --id corneliusludmann-admin-panel-delete-2849
  • Find a user to delete (in doubt login with another user account)
  • Hit the delete button and follow the steps
  • Delete button is disabled when the “self” user or when the user is already deleted.

Fixes #2849

@corneliusludmann corneliusludmann changed the title WIP: [admin panel] Add delete user button [admin panel] Add delete user button Jan 13, 2021
@corneliusludmann corneliusludmann force-pushed the corneliusludmann/admin-panel-delete-2849 branch from 76b9a3a to 9f7d653 Compare January 13, 2021 11:29
@corneliusludmann corneliusludmann force-pushed the corneliusludmann/admin-panel-delete-2849 branch from 9f7d653 to 1060e98 Compare January 13, 2021 11:38
csweichel
csweichel approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. LGTM.

@corneliusludmann corneliusludmann merged commit 225e102 into master Jan 13, 2021
@corneliusludmann corneliusludmann deleted the corneliusludmann/admin-panel-delete-2849 branch January 13, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

@geropl geropl Awaiting requested review from geropl

@akosyakov akosyakov Awaiting requested review from akosyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[admin panel] Delete User
3 participants
@corneliusludmann @akosyakov @csweichel